We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
string
The types via node_modules/bowser/index.d.ts aren't extremely useful
node_modules/bowser/index.d.ts
Most variables are just string rather than explaining what the actual values could be (eg 'MacOS' | 'Windows' or 'macos' | 'windows')
'MacOS' | 'Windows'
'macos' | 'windows'
I believe the source code probably has explicit values for these, and that the types could be defined better:
const BROWSER_MAP: Record<string, string>; const ENGINE_MAP: Record<string, string>; const OS_MAP: Record<string, string>; const PLATFORMS_MAP: Record<string, string>;
The text was updated successfully, but these errors were encountered:
Hi @neaumusic! Thanks for the feedback! I have an idea to refactor it on Typescript to provide a better and native way to support types.
Sorry, something went wrong.
No branches or pull requests
The types via
node_modules/bowser/index.d.ts
aren't extremely usefulMost variables are just
string
rather than explaining what the actual values could be (eg'MacOS' | 'Windows'
or'macos' | 'windows'
)I believe the source code probably has explicit values for these, and that the types could be defined better:
The text was updated successfully, but these errors were encountered: