diff --git a/src/render/BpmnPropertiesPanel.js b/src/render/BpmnPropertiesPanel.js index 2f2d97f7..961a17f7 100644 --- a/src/render/BpmnPropertiesPanel.js +++ b/src/render/BpmnPropertiesPanel.js @@ -250,9 +250,7 @@ export default function BpmnPropertiesPanel(props) { // helpers ////////////////////////// function isImplicitRoot(element) { - - // Backwards compatibility for diagram-js<7.4.0, see https://github.com/bpmn-io/bpmn-properties-panel/pull/102 - return element && (element.isImplicit || element.id === '__implicitroot'); + return element && element.isImplicit; } function findElement(elements, element) { diff --git a/src/render/BpmnPropertiesPanelRenderer.js b/src/render/BpmnPropertiesPanelRenderer.js index db74f6c0..95a328c7 100644 --- a/src/render/BpmnPropertiesPanelRenderer.js +++ b/src/render/BpmnPropertiesPanelRenderer.js @@ -201,9 +201,7 @@ BpmnPropertiesPanelRenderer.$inject = [ 'config.propertiesPanel', 'injector', 'e // helpers /////////////////////// function isImplicitRoot(element) { - - // Backwards compatibility for diagram-js<7.4.0, see https://github.com/bpmn-io/bpmn-properties-panel/pull/102 - return element && (element.isImplicit || element.id === '__implicitroot'); + return element && element.isImplicit; } /** diff --git a/test/spec/BpmnPropertiesPanelRenderer.spec.js b/test/spec/BpmnPropertiesPanelRenderer.spec.js index 30a836e1..b0b3536d 100644 --- a/test/spec/BpmnPropertiesPanelRenderer.spec.js +++ b/test/spec/BpmnPropertiesPanelRenderer.spec.js @@ -401,32 +401,6 @@ describe('', function() { }); - it('should ignore implicit root - legacy', async function() { - - // given - const diagramXml = require('test/fixtures/simple.bpmn').default; - - // when - const { modeler } = await createModeler(diagramXml, { - shouldImport: false, - propertiesPanel: {} - }); - - const implicitRootElement = { - id: '__implicitroot', - children: [] - }; - - // when - const propertiesPanel = modeler.get('propertiesPanel'); - propertiesPanel.attachTo(propertiesContainer); - propertiesPanel._render(implicitRootElement); - - // then - expect(domQuery('.bio-properties-panel', propertiesContainer)).to.not.exist; - }); - - describe('providers', function() { const diagramXML = require('test/fixtures/simple.bpmn').default;