Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed expression language indicator not shown #647

Open
Egoplayer opened this issue Jul 1, 2021 · 2 comments
Open

Changed expression language indicator not shown #647

Egoplayer opened this issue Jul 1, 2021 · 2 comments
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this.

Comments

@Egoplayer
Copy link

Egoplayer commented Jul 1, 2021

Describe the Bug

The DMN Editor doesn't show the set expression language for some dmn cells. If the expression language is changed from the default FEEL to any other expression language a blue indicator appears on the right side of the cell to show there is a changed expression language active. This does only work for every second cell.

dmn_script_indicators

Hover over the cells shows the extended indicated (shows the set expression language) anyway even if the blue indicator is not shown
Steps to Reproduce

  1. Create a new DMN via the online modeler https://demo.bpmn.io/dmn
  2. Add 2-3 rules (rows)
  3. change the expression language for every input cell to another expression language (e.g. Javascript)

The Issue should occur in lines 2, 4, 6, ...

Expected Behavior

I expect to show this blue indicator in every cell if the expression language is changed

Environment

  • Browser: Chrome 90
  • OS: Windows 10
  • Library version: 10.0.0 + latest
@Egoplayer Egoplayer added the bug Something isn't working label Jul 1, 2021
@Egoplayer Egoplayer changed the title Changed script language indicator not shown Changed expression language indicator not shown Jul 1, 2021
@people-ware
Copy link

I think this is caused by

.dmn-decision-table-container .cell .dms-badge.dmn-expression-language {
  z-index: -1;
}

in https://github.com/bpmn-io/dmn-js/blob/develop/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css#L536

@pinussilvestrus
Copy link
Contributor

Thanks for reporting! This relates to camunda/camunda-modeler#1678

Feel free to open a PR that improves the situation!

@pinussilvestrus pinussilvestrus added backlog Queued in backlog pr welcome We rely on a community contribution to improve this. labels Jul 1, 2021
@pinussilvestrus pinussilvestrus added the good first issue Good for newcomers label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers pr welcome We rely on a community contribution to improve this.
Projects
None yet
Development

No branches or pull requests

3 participants