Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop transpilation #814

Open
nikku opened this issue Dec 21, 2023 · 3 comments
Open

Drop transpilation #814

nikku opened this issue Dec 21, 2023 · 3 comments
Labels
backlog Queued in backlog spring cleaning Could be cleaned up one day

Comments

@nikku
Copy link
Member

nikku commented Dec 21, 2023

What should we do?

Given that we lifted our language level to ES2018 we can now drop our transpilation of classes.

Why should we do it?

Ensure that our bundles are as small as possible.

@nikku nikku mentioned this issue Dec 21, 2023
@nikku nikku added the spring cleaning Could be cleaned up one day label Dec 22, 2023
@barmac
Copy link
Member

barmac commented Dec 22, 2023

We could probably drop transpilation for dmn-js-drd, but for Inferno-based libraries we still need to somehow handle JSX.

AFAIK we don't transpile classes since the migration, e.g. https://unpkg.com/browse/[email protected]/lib/Editor.js

@nikku
Copy link
Member Author

nikku commented Dec 22, 2023

I'd love us to transpile only what is absolutely necessary. Right now we transpile many things, and we cannot use @babel/preset-env to define a clear target (ES2018).

@nikku nikku added the backlog Queued in backlog label Dec 22, 2023
@barmac
Copy link
Member

barmac commented Dec 22, 2023

Ideally, I'd use babel only to support the latest browsers. This is what we declared anyway. ES2018 was set as a target to prevent transpilation, but in dmn-js we can't work without it at the moment due to Inferno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

2 participants