Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse decision table inputs as unary tests #880

Open
barmac opened this issue Jun 3, 2024 · 1 comment · May be fixed by #881
Open

Parse decision table inputs as unary tests #880

barmac opened this issue Jun 3, 2024 · 1 comment · May be fixed by #881
Assignees
@nikku
Labels
bug Something isn't working Decision Table ready Ready to be worked on

Comments

@barmac
Copy link
Member

barmac commented Jun 3, 2024

Describe the Bug

Currently, the decision table parses input cells values as expressions. This leads to misleading syntax errors as in the screenshot below:

image

Steps to Reproduce

Pass unary tests separated by comma to the input cell.

Expected Behavior

Should be parsed as Unary Test.

Context

Reported via https://camunda.slack.com/archives/C0693F1NFK5/p1717418704931359

Ideally, this should be configurable in the feel-editor
@barmac barmac added the bug Something isn't working label Jun 3, 2024
@nikku nikku added the ready Ready to be worked on label Jun 4, 2024
@nikku nikku self-assigned this Jun 4, 2024
@nikku nikku mentioned this issue Jun 4, 2024
Merged
@nikku
Copy link
Member

nikku commented Jun 4, 2024

Upstream fix pending integration: bpmn-io/feel-editor#53.

nikku added a commit that referenced this issue Jun 4, 2024
@nikku
feat(decision-table): parse FEEL input cells as unary tests
8ac0e58 
Closes #880
@nikku nikku linked a pull request Jun 4, 2024 that will close this issue
Draft
1 task
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 4, 2024
@nikku nikku added the ready Ready to be worked on label Jul 1, 2024 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Jul 1, 2024
@philippfromme philippfromme changed the title Parse decision table inputs ast UnaryTests Parse decision table inputs as UnaryTests Jul 23, 2024
@philippfromme philippfromme changed the title Parse decision table inputs as UnaryTests Parse decision table inputs as unary tests Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working Decision Table ready Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(decision-table): parse FEEL input cells as unary tests bpmn-io/dmn-js
2 participants
@nikku @barmac