From 693530c2c053d3f7911e433d87de90c7ee0609ad Mon Sep 17 00:00:00 2001 From: brianjvarley Date: Thu, 16 Nov 2023 13:07:10 +0100 Subject: [PATCH 01/17] ViewDrdComp: Add tabIndex and include focus outline styling, DrillDownComp: Apply tabindex=o attribute to catch keyboard focus & change element from span -> button to capture enter enter key event and drill down --- .../assets/css/dmn-js-decision-table.css | 6 +++++ .../view-drd/components/ViewDrdComponent.js | 1 + .../src/features/drill-down/DrillDown.js | 6 ++++- .../spec/features/drill-down/DrillDownSpec.js | 26 ++++++++++++++++++- 4 files changed, 37 insertions(+), 2 deletions(-) diff --git a/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css b/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css index 67b42f89a..58bd0a7ed 100644 --- a/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css +++ b/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css @@ -38,6 +38,7 @@ --view-drd-button-border-color: var(--color-grey-225-10-75); --view-drd-button-color: var(--color-grey-225-10-15); --view-drd-button-hover-background-color: var(--color-grey-225-10-97); + --view-drd-button-focus-border-color: var(--color-blue-205-100-50); --decision-table-font-family: 'Arial', sans-serif; width: 100%; @@ -426,6 +427,11 @@ background: var(--view-drd-button-hover-background-color); } +/* Adds the missing focus outline to button */ +.dmn-decision-table-container .view-drd .view-drd-button:focus { + border: 1px solid var(--view-drd-button-focus-border-color); +} + /* end view drd */ /* powered by */ diff --git a/packages/dmn-js-decision-table/src/features/view-drd/components/ViewDrdComponent.js b/packages/dmn-js-decision-table/src/features/view-drd/components/ViewDrdComponent.js index a0c637b9d..12a49d9bc 100644 --- a/packages/dmn-js-decision-table/src/features/view-drd/components/ViewDrdComponent.js +++ b/packages/dmn-js-decision-table/src/features/view-drd/components/ViewDrdComponent.js @@ -22,6 +22,7 @@ export default class ViewDrdComponent extends Component { className="view-drd" ref={ node => this.node = node }> diff --git a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js index ce338d45a..f548891aa 100644 --- a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js +++ b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js @@ -3,6 +3,7 @@ import { is } from 'dmn-js-shared/lib/util/ModelUtil'; import { domify, classes as domClasses, + attr as domAttr, delegate as domDelegate } from 'min-dom'; @@ -71,7 +72,7 @@ export default class DrillDown { addOverlay(element, className) { const html = domify(`
- +
`); @@ -87,6 +88,9 @@ export default class DrillDown { if (this._config.enabled !== false) { domClasses(html).add('interactive'); + // Add tabindex attr. to allow keyboard tab focus on Drilldown button + domAttr(html, 'tabindex', '0'); + this.bindEventListener(element, html, overlayId); } } diff --git a/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js b/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js index 1367529ba..8951cbecf 100644 --- a/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js +++ b/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js @@ -17,7 +17,9 @@ import { } from 'min-dom'; import { - triggerClick + triggerClick, + triggerFocusIn, + triggerKeyEvent } from 'dmn-js-shared/test/util/EventUtil'; var diagramXML = require('./DrillDown.dmn'); @@ -252,6 +254,28 @@ describe('features - drilldown', function() { } )); + // FIXME: + xit('on Enter key pressed', inject( + function(eventBus, drillDown, elementRegistry) { + + // given + var drillSpy = sinon.spy(drillDown, 'drillDown'); + + var overlayEl = queryOverlay('Decision_Table'); + console.log(overlayEl.innerHTML); + + // when + // press ENTER + triggerFocusIn(overlayEl); + triggerKeyEvent(overlayEl, 'keydown', 13); + + // then + expect(drillSpy).to.have.been.calledOnce; + + expect(drillSpy).to.have.been.calledWith(overlayEl); + } + )); + }); From fa702581fcc58780c9e45adddadee4adb430d0e7 Mon Sep 17 00:00:00 2001 From: brianjvarley Date: Thu, 16 Nov 2023 16:35:02 +0100 Subject: [PATCH 02/17] DrillDown: remove tabIndex as overlay button will receive focus natively --- packages/dmn-js-drd/src/features/drill-down/DrillDown.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js index f548891aa..cf6fb9a70 100644 --- a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js +++ b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js @@ -87,10 +87,6 @@ export default class DrillDown { // TODO(nikku): can we remove renamed to drillDown.enabled if (this._config.enabled !== false) { domClasses(html).add('interactive'); - - // Add tabindex attr. to allow keyboard tab focus on Drilldown button - domAttr(html, 'tabindex', '0'); - this.bindEventListener(element, html, overlayId); } } From f34973095b4cdf3037a9596bc20e7020d8118594 Mon Sep 17 00:00:00 2001 From: brianjvarley Date: Fri, 17 Nov 2023 12:05:57 +0100 Subject: [PATCH 03/17] ViewDrdComp: remove tabindex attr. since button natively receives focus, .view-drd-button: Remove outline: none style to allow browser native focus style to be applied to button --- .../assets/css/dmn-js-decision-table.css | 5 ++--- .../src/features/view-drd/components/ViewDrdComponent.js | 1 - packages/dmn-js-shared/test/util/EventUtil.js | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css b/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css index 58bd0a7ed..293eb937f 100644 --- a/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css +++ b/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css @@ -420,7 +420,6 @@ color: var(--view-drd-button-color); font-weight: bold; cursor: pointer; - outline: none; } .dmn-decision-table-container .view-drd .view-drd-button:hover { @@ -428,9 +427,9 @@ } /* Adds the missing focus outline to button */ -.dmn-decision-table-container .view-drd .view-drd-button:focus { +/* .dmn-decision-table-container .view-drd .view-drd-button:focus { border: 1px solid var(--view-drd-button-focus-border-color); -} +} */ /* end view drd */ diff --git a/packages/dmn-js-decision-table/src/features/view-drd/components/ViewDrdComponent.js b/packages/dmn-js-decision-table/src/features/view-drd/components/ViewDrdComponent.js index 12a49d9bc..a0c637b9d 100644 --- a/packages/dmn-js-decision-table/src/features/view-drd/components/ViewDrdComponent.js +++ b/packages/dmn-js-decision-table/src/features/view-drd/components/ViewDrdComponent.js @@ -22,7 +22,6 @@ export default class ViewDrdComponent extends Component { className="view-drd" ref={ node => this.node = node }> diff --git a/packages/dmn-js-shared/test/util/EventUtil.js b/packages/dmn-js-shared/test/util/EventUtil.js index a5f9fedb1..2b4b6cdda 100644 --- a/packages/dmn-js-shared/test/util/EventUtil.js +++ b/packages/dmn-js-shared/test/util/EventUtil.js @@ -70,7 +70,6 @@ export function triggerKeyEvent(element, event, optionsOrCode) { e.keyCode = optionsOrCode; e.which = optionsOrCode; } - return element.dispatchEvent(e); } From 05e9deacc0aadf77e645344eccb422a29b5000cd Mon Sep 17 00:00:00 2001 From: brianjvarley Date: Fri, 17 Nov 2023 16:02:22 +0100 Subject: [PATCH 04/17] view-drd-button: remove custom focus style, now provided by button element --- .../assets/css/dmn-js-decision-table.css | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css b/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css index 293eb937f..36640aed3 100644 --- a/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css +++ b/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css @@ -426,11 +426,6 @@ background: var(--view-drd-button-hover-background-color); } -/* Adds the missing focus outline to button */ -/* .dmn-decision-table-container .view-drd .view-drd-button:focus { - border: 1px solid var(--view-drd-button-focus-border-color); -} */ - /* end view drd */ /* powered by */ From 5ea5a0d7ceb50752ec38cda0048f20d1994dbb0f Mon Sep 17 00:00:00 2001 From: Brian Varley Date: Thu, 23 Nov 2023 21:53:27 +0100 Subject: [PATCH 05/17] clean up unused code in PR --- .../dmn-js-decision-table/assets/css/dmn-js-decision-table.css | 1 - packages/dmn-js-drd/src/features/drill-down/DrillDown.js | 1 - 2 files changed, 2 deletions(-) diff --git a/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css b/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css index 36640aed3..db7850283 100644 --- a/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css +++ b/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css @@ -38,7 +38,6 @@ --view-drd-button-border-color: var(--color-grey-225-10-75); --view-drd-button-color: var(--color-grey-225-10-15); --view-drd-button-hover-background-color: var(--color-grey-225-10-97); - --view-drd-button-focus-border-color: var(--color-blue-205-100-50); --decision-table-font-family: 'Arial', sans-serif; width: 100%; diff --git a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js index cf6fb9a70..a99bb143e 100644 --- a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js +++ b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js @@ -3,7 +3,6 @@ import { is } from 'dmn-js-shared/lib/util/ModelUtil'; import { domify, classes as domClasses, - attr as domAttr, delegate as domDelegate } from 'min-dom'; From 3d772d368615c78e9fd21896c8000c2ece89c129 Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Tue, 28 Nov 2023 11:36:35 +0100 Subject: [PATCH 06/17] fix: add type=button --- packages/dmn-js-drd/src/features/drill-down/DrillDown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js index a99bb143e..08420410f 100644 --- a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js +++ b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js @@ -71,7 +71,7 @@ export default class DrillDown { addOverlay(element, className) { const html = domify(`
- +
`); From 146a9c973f88c70643895d628743cb19c2ac9fa7 Mon Sep 17 00:00:00 2001 From: Brian Varley Date: Tue, 28 Nov 2023 15:40:18 +0100 Subject: [PATCH 07/17] DrillDown: Add blue background & white color styling to button element @barmac --- packages/dmn-js-drd/assets/css/dmn-js-drd.css | 11 +++++++++++ .../dmn-js-drd/src/features/drill-down/DrillDown.js | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/dmn-js-drd/assets/css/dmn-js-drd.css b/packages/dmn-js-drd/assets/css/dmn-js-drd.css index bece415c4..2b0b2c50b 100644 --- a/packages/dmn-js-drd/assets/css/dmn-js-drd.css +++ b/packages/dmn-js-drd/assets/css/dmn-js-drd.css @@ -6,6 +6,7 @@ --dmn-definitions-error-border-color: var(--color-red-360-100-45); --dmn-definitions-error-background-color: var(--color-red-360-100-97); --drill-down-overlay-background-color: var(--color-blue-205-100-50); + --drill-down-button-background-color: var(--color-blue-205-100-50); --drill-down-overlay-color: var(--color-white); --drd-font-family-monospace: monospace; @@ -18,6 +19,16 @@ box-sizing: border-box; } +.dmn-icon-decision-table { + background: var(--drill-down-button-background-color); + color: var(--drill-down-overlay-color); +} + +.dmn-icon-literal-expression { + background: var(--drill-down-button-background-color); + color: var(--drill-down-overlay-color); +} + .djs-overlay .drill-down-overlay { font-size: 16px; background: var(--drill-down-overlay-background-color); diff --git a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js index 08420410f..ff959600e 100644 --- a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js +++ b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js @@ -71,7 +71,7 @@ export default class DrillDown { addOverlay(element, className) { const html = domify(`
- +
`); From 53af083f6f0a4abbe0fb8004b6e31841364153d0 Mon Sep 17 00:00:00 2001 From: Brian Varley Date: Tue, 28 Nov 2023 15:40:55 +0100 Subject: [PATCH 08/17] drilldown: remove unused css class --- packages/dmn-js-drd/src/features/drill-down/DrillDown.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js index ff959600e..08420410f 100644 --- a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js +++ b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js @@ -71,7 +71,7 @@ export default class DrillDown { addOverlay(element, className) { const html = domify(`
- +
`); From c41fde62fe1a012528b0aadf85c3745e9a237a6b Mon Sep 17 00:00:00 2001 From: Brian Varley Date: Mon, 4 Dec 2023 11:24:24 +0100 Subject: [PATCH 09/17] dmn-js-drd.css: remove background color on drilldown button so Browser tab focus style is visible (.djs-overlay .drill-down-overlay) --- packages/dmn-js-drd/assets/css/dmn-js-drd.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dmn-js-drd/assets/css/dmn-js-drd.css b/packages/dmn-js-drd/assets/css/dmn-js-drd.css index 2b0b2c50b..e24b4339b 100644 --- a/packages/dmn-js-drd/assets/css/dmn-js-drd.css +++ b/packages/dmn-js-drd/assets/css/dmn-js-drd.css @@ -31,7 +31,7 @@ .djs-overlay .drill-down-overlay { font-size: 16px; - background: var(--drill-down-overlay-background-color); + /* background: var(--drill-down-overlay-background-color); */ color: var(--drill-down-overlay-color); text-align: left; border-radius: 1px; From 7ee24ff9a112249f4c737a3e1293e47ef07a31ae Mon Sep 17 00:00:00 2001 From: Brian Varley Date: Mon, 4 Dec 2023 11:30:23 +0100 Subject: [PATCH 10/17] dmn-js-drd.css: remove background color on drilldown button so Browser tab focus style is visible (.djs-overlay .drill-down-overlay)..remove style prop --- packages/dmn-js-drd/assets/css/dmn-js-drd.css | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/dmn-js-drd/assets/css/dmn-js-drd.css b/packages/dmn-js-drd/assets/css/dmn-js-drd.css index e24b4339b..74c960a64 100644 --- a/packages/dmn-js-drd/assets/css/dmn-js-drd.css +++ b/packages/dmn-js-drd/assets/css/dmn-js-drd.css @@ -31,7 +31,6 @@ .djs-overlay .drill-down-overlay { font-size: 16px; - /* background: var(--drill-down-overlay-background-color); */ color: var(--drill-down-overlay-color); text-align: left; border-radius: 1px; From 77c13cc45cdc982632b9c7fd1f868673d74227d4 Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Wed, 6 Dec 2023 11:37:35 +0100 Subject: [PATCH 11/17] chore: improve colors --- packages/dmn-js-drd/assets/css/dmn-js-drd.css | 23 ++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/packages/dmn-js-drd/assets/css/dmn-js-drd.css b/packages/dmn-js-drd/assets/css/dmn-js-drd.css index 74c960a64..59155839f 100644 --- a/packages/dmn-js-drd/assets/css/dmn-js-drd.css +++ b/packages/dmn-js-drd/assets/css/dmn-js-drd.css @@ -6,7 +6,6 @@ --dmn-definitions-error-border-color: var(--color-red-360-100-45); --dmn-definitions-error-background-color: var(--color-red-360-100-97); --drill-down-overlay-background-color: var(--color-blue-205-100-50); - --drill-down-button-background-color: var(--color-blue-205-100-50); --drill-down-overlay-color: var(--color-white); --drd-font-family-monospace: monospace; @@ -19,22 +18,20 @@ box-sizing: border-box; } -.dmn-icon-decision-table { - background: var(--drill-down-button-background-color); - color: var(--drill-down-overlay-color); -} - -.dmn-icon-literal-expression { - background: var(--drill-down-button-background-color); - color: var(--drill-down-overlay-color); -} - .djs-overlay .drill-down-overlay { font-size: 16px; - color: var(--drill-down-overlay-color); text-align: left; + padding: 1px; +} + +.djs-overlay .drill-down-overlay > button { + padding: 2px 4px; + margin: 0; + border: none; border-radius: 1px; - padding: 0 2px; + background: var(--drill-down-overlay-background-color); + color: var(--drill-down-overlay-color); + font-size: inherit; } .dmn-definitions { From d7522bbc3cdcd74c6689aaf8fc488d0f46fe844d Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Wed, 6 Dec 2023 11:41:33 +0100 Subject: [PATCH 12/17] fix: show outline for view-drd button --- .../assets/css/dmn-js-literal-expression.css | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/dmn-js-literal-expression/assets/css/dmn-js-literal-expression.css b/packages/dmn-js-literal-expression/assets/css/dmn-js-literal-expression.css index 363aa8c34..402d1c4bd 100644 --- a/packages/dmn-js-literal-expression/assets/css/dmn-js-literal-expression.css +++ b/packages/dmn-js-literal-expression/assets/css/dmn-js-literal-expression.css @@ -157,7 +157,6 @@ color: var(--view-drd-button-color); font-weight: bold; cursor: pointer; - outline: none; } .dmn-literal-expression-container .view-drd .view-drd-button:hover { From 990a8d2a9683643719526062ad618d405007f4e9 Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Wed, 6 Dec 2023 12:09:05 +0100 Subject: [PATCH 13/17] feat: display span for non-interactive --- packages/dmn-js-drd/assets/css/dmn-js-drd.css | 4 +++- packages/dmn-js-drd/src/features/drill-down/DrillDown.js | 7 +++++-- .../test/spec/features/drill-down/DrillDownSpec.js | 8 +++++--- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/packages/dmn-js-drd/assets/css/dmn-js-drd.css b/packages/dmn-js-drd/assets/css/dmn-js-drd.css index 59155839f..0d5bd1c61 100644 --- a/packages/dmn-js-drd/assets/css/dmn-js-drd.css +++ b/packages/dmn-js-drd/assets/css/dmn-js-drd.css @@ -24,7 +24,9 @@ padding: 1px; } -.djs-overlay .drill-down-overlay > button { +.djs-overlay .drill-down-overlay > button, +.djs-overlay .drill-down-overlay > span { + display: block; padding: 2px 4px; margin: 0; border: none; diff --git a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js index 08420410f..abe3ec1f1 100644 --- a/packages/dmn-js-drd/src/features/drill-down/DrillDown.js +++ b/packages/dmn-js-drd/src/features/drill-down/DrillDown.js @@ -69,9 +69,12 @@ export default class DrillDown { * CSS class that will be added to overlay in order to display icon. */ addOverlay(element, className) { + const enabled = this._config.enabled !== false; + const html = domify(`
- + ${ enabled ? `` : + ``}
`); @@ -84,7 +87,7 @@ export default class DrillDown { }); // TODO(nikku): can we remove renamed to drillDown.enabled - if (this._config.enabled !== false) { + if (enabled) { domClasses(html).add('interactive'); this.bindEventListener(element, html, overlayId); } diff --git a/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js b/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js index 8951cbecf..8d8a00b29 100644 --- a/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js +++ b/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js @@ -192,7 +192,7 @@ describe('features - drilldown', function() { }); - describe('should show correct icon', function() { + describe.only('should show correct icon', function() { verify( 'decision table', @@ -217,6 +217,7 @@ describe('features - drilldown', function() { // then expect(matches(overlayEl, '.interactive')).to.be.false; + expect(query('button', overlayEl)).to.be.null; expect(iconEl).to.exist; }); @@ -254,8 +255,9 @@ describe('features - drilldown', function() { } )); - // FIXME: - xit('on Enter key pressed', inject( + // TODO(@barmac): browser emits 'click' event on ENTER key press + // but not for synthetic events + it.skip('on Enter key pressed', inject( function(eventBus, drillDown, elementRegistry) { // given From 893713303fe499cc7a02875f9eb80a5def81683b Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Wed, 6 Dec 2023 12:22:39 +0100 Subject: [PATCH 14/17] test: remove exclusive test --- .../dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js b/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js index 8d8a00b29..9a752b54c 100644 --- a/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js +++ b/packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js @@ -192,7 +192,7 @@ describe('features - drilldown', function() { }); - describe.only('should show correct icon', function() { + describe('should show correct icon', function() { verify( 'decision table', From ecc4f269d3d1415a44087570ac118ac353ee17f9 Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Wed, 6 Dec 2023 17:12:40 +0100 Subject: [PATCH 15/17] test: revert unnecessary change --- packages/dmn-js-shared/test/util/EventUtil.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/dmn-js-shared/test/util/EventUtil.js b/packages/dmn-js-shared/test/util/EventUtil.js index 2b4b6cdda..a5f9fedb1 100644 --- a/packages/dmn-js-shared/test/util/EventUtil.js +++ b/packages/dmn-js-shared/test/util/EventUtil.js @@ -70,6 +70,7 @@ export function triggerKeyEvent(element, event, optionsOrCode) { e.keyCode = optionsOrCode; e.which = optionsOrCode; } + return element.dispatchEvent(e); } From 35100bad1d03dc1fa7896be6f6c8388d3768935b Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Thu, 7 Dec 2023 13:51:00 +0100 Subject: [PATCH 16/17] increase outline offset --- packages/dmn-js-drd/assets/css/dmn-js-drd.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/dmn-js-drd/assets/css/dmn-js-drd.css b/packages/dmn-js-drd/assets/css/dmn-js-drd.css index 0d5bd1c61..3708d5430 100644 --- a/packages/dmn-js-drd/assets/css/dmn-js-drd.css +++ b/packages/dmn-js-drd/assets/css/dmn-js-drd.css @@ -34,6 +34,8 @@ background: var(--drill-down-overlay-background-color); color: var(--drill-down-overlay-color); font-size: inherit; + + outline-offset: 2px; } .dmn-definitions { From 539ad76eee087e1582c5d602145232c6d050feff Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Thu, 7 Dec 2023 13:55:16 +0100 Subject: [PATCH 17/17] lol --- packages/dmn-js-drd/assets/css/dmn-js-drd.css | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/dmn-js-drd/assets/css/dmn-js-drd.css b/packages/dmn-js-drd/assets/css/dmn-js-drd.css index 3708d5430..628ed9925 100644 --- a/packages/dmn-js-drd/assets/css/dmn-js-drd.css +++ b/packages/dmn-js-drd/assets/css/dmn-js-drd.css @@ -34,7 +34,6 @@ background: var(--drill-down-overlay-background-color); color: var(--drill-down-overlay-color); font-size: inherit; - outline-offset: 2px; }