test(refs): added tests for ref utility #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The specs are testing the internal utilities here. What about using the refs with actual components, dom elements and testing if we are getting expected values on ref are not. |
|
We probably can reuse the specs from React. You can also check for Preact specs. |
s-yadav
reviewed
Nov 10, 2019
| }); | ||
| }); | ||
|
|
||
| it('should set instance as current when setRef called with object type ref', () => { |
There was a problem hiding this comment.
setRef is inner API we should do integration test of it. Similar to what you did for forwardRefs.
| expect(ref.current).toBe('instance'); | ||
| }); | ||
|
|
||
| it('should pass instance as param when setRef called with function type ref', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #45