Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Bolt12 parsing into sdk-common #573

Open
4 tasks
ok300 opened this issue Nov 19, 2024 · 0 comments
Open
4 tasks

Consolidate Bolt12 parsing into sdk-common #573

ok300 opened this issue Nov 19, 2024 · 0 comments

Comments

@ok300
Copy link
Contributor

ok300 commented Nov 19, 2024

The input_parser lives in sdk-common, however the logic to parse Bolt12 offers exists only in the Liquid SDK.

This separation was done because the parsing logic required lightning of at least version 0.0.125. Once gl-client supports it, we can move this custom parsing logic back into sdk-common.


Depends on

Next steps

  • GL SDK: bump gl_client to include the above
  • breez-sdk-liquid: bump sdk-common dependency to use the above
  • breez-sdk-liquid: remove custom lightning dependency, re-use the one from sdk-common (which is a re-export of the gl_client one)
  • breez-sdk-liquid: move logic for parsing Bolt12 offers (introduced in Add support for paying to BOLT12 #549) into sdk-common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant