Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching the balance mixes different assets #628

Open
victor-piekarski opened this issue Dec 22, 2024 · 3 comments
Open

Fetching the balance mixes different assets #628

victor-piekarski opened this issue Dec 22, 2024 · 3 comments

Comments

@victor-piekarski
Copy link

Issue
sdk.get_info() shows mixed balance of different assets.

Description
By accident, I've sent 1 USDT to my liquid address and now my wallet shows me that I have 1 L-BTC. I also have 6,600 LBTC SATS there, so now I keep getting my balance mixed. In response from sdk.get_info() the total sum shows up like 100,006,600 SATS.
I know that Breez doesn't support USDT yet, but we can still have a situation like this.
Please have a look at my suggestion below.

Expected behavior
I would like to have my wallet's balance details separated by asset.

Suggestion
It would be really useful to have details been added to response from sdk.get_info(). Now it returns this object:

{
  balance_sat: number;
  pending_send_sat: number;
  pending_receive_sat: number;
  fingerprint: number;
  pubkey: string;
}

and the issue could be resolved by adding asset details to this response. Something like this:

{
  balance_sat: number;
  pending_send_sat: number;
  pending_receive_sat: number;
  fingerprint: number;
  pubkey: string;
  assets: [
    {
      asset_id: string;
      balance: number;
      ticker: 'L-BTC' | 'USDt'
    }
  ]
}

Environment
Breez SDK Liquid for Python, v. 0.5.1
MAINNET

Thanks for your work!

@Ellabell-dr

This comment was marked as abuse.

@kingonly
Copy link
Member

This will be resolved once we support multiple assets which is next on our roadmap.

@Jaynelauren

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@kingonly @victor-piekarski @Jaynelauren @Ellabell-dr and others