Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list payments to include chain swaps with only user lockup #620

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

dangeross
Copy link
Collaborator

@dangeross dangeross commented Dec 19, 2024

This PR allows a payment event to be emitted without a tx_id and updates the payments query to:

  • do a FULL JOIN with the chain_swaps table (include chain swaps without claim txs) filtering out where the swap state is Created or TimedOut
  • filter out receive_swaps where the swap state is Created, Failed or TimedOut

Fixes breez/misty-breez#276

{
    "destination": null,
    "tx_id": null,
    "timestamp": 1734626434,
    "amount_sat": 47796,
    "fees_sat": 2204,
    "swapper_fees_sat": 50,
    "payment_type": "Receive",
    "status": "Pending",
    "details": {
         "Bitcoin": {
             "swap_id": "tYJ9vuAa828n",
             "description": "Bitcoin transfer",
             "refund_tx_id": null,
             "refund_tx_amount_sat": null
         }
    }
}

@dangeross dangeross force-pushed the savage-receive-chain-pending branch from ba8e0ac to d572465 Compare December 19, 2024 18:40
@dangeross dangeross changed the base branch from main to rt-sync December 19, 2024 18:40
Copy link
Contributor

@danielgranhao danielgranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@dangeross dangeross merged commit 34bc791 into rt-sync Dec 23, 2024
9 checks passed
@dangeross dangeross deleted the savage-receive-chain-pending branch December 23, 2024 12:15
hydra-yse pushed a commit that referenced this pull request Dec 24, 2024
* Update payments query to include chain swaps without txs

* Allow emitting a payment event without tx_id
hydra-yse added a commit that referenced this pull request Dec 24, 2024
* feat(rt-sync): add persistency layer (#555)

* feat(rt-sync): add pull and merge (#556)

* feat(rt-sync): add push logic and run method (#568)

* feat(rt-sync): integrate rt-sync with the sdk

fix: add formatting command to build

feat: add secondary trigger to sync

deps: add tonic tls-webpki-roots

feat: prevent double claiming on status stream handlers

fix: add tx commit to chain swap update (#588)

fix: ensure we pull records before prepare_send

fix: fmt and tests

* fix: set initial pulled state to `Recoverable`

* feat(rt-sync): add `last_derivation_index` to sync service

* Single chain source

* Handle Recoverable state

* fix(rt-sync): chain recovery integration (#590)

Co-authored-by: yse <[email protected]>

* feat(rt-sync): add `pair_fees_json`

* fix(rt-sync): clean already persisted incoming records

* feat: cache wallet info (#591)

* log: add status-stream logging for non-local swaps

* Sync improvements (#598)

* Full sync on new Bitcoin block

* Track the last unconfirmed refund tx

* Trigger synced event on partial sync

* fix: remove `REPLACE` clause from swap insert/update

* fix(rt-sync): update chain swap payer/receiver amount (#604)

* Fix syncing last derivation index

* fix: update bindings and lockfile

* remove logs

* fix(rt-sync): avoid reuse of derivation index update logic (#608)

* Add 5 index buffer to full scan

* Fix storing claim_address (#609)

* Filter incoming MRH txs by swap timestamp

* fix liquid panding timestamp

* persist tx data timestamp

* Update unconfirmed transactions

* feat: add API key (#618)

* Use configured lazy connect channel in sync service

* fix: set lower-case header (#624)

* fix error message

* Store & Sync LNURL info (#617)

* Persist and decrypt LNURL info

* Update Notification Plugin

* Sync payment details

* Update list payments to include chain swaps with only user lockup (#620)

* Update payments query to include chain swaps without txs

* Allow emitting a payment event without tx_id

* fix: bindings

---------

Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Roei Erez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving onchain pending transaction is not shown
3 participants