Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informative text on command line interface. #510

Closed
mcagriaksoy opened this issue Dec 2, 2024 · 3 comments
Closed

Informative text on command line interface. #510

mcagriaksoy opened this issue Dec 2, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mcagriaksoy
Copy link
Contributor

New Feature Description

Hi Brent,
I think a text which displays in command line to inform user program is running might be helpful.

Reason For New Feature
It is because when user runs the auto-py-to-exe, it opens a web browser and/or tab automatically, but it might be missing by the user, or user might minimize the browser.

image

So that, when user opens the command line interface, cannot see anything and might understand that software cannot responding.
I think we can add an informative text like:

  • Please do not close this window, software is running at web-browser.
  • Please continue on browser etc. etc.

What do you think?

@mcagriaksoy mcagriaksoy added the enhancement New feature or request label Dec 2, 2024
Repository owner deleted a comment from github-actions bot Dec 2, 2024
@brentvollebregt
Copy link
Owner

Yea, this is a really good idea!

There are 4 different states the UI can be displayed:

  1. Chrome's app mode is automatically opened (default)
  2. Edge's app mode is automatically opened (default if Chrome is not installed)
  3. The default browser is automatically opened (default if Chrome and Edge are not installed)
  4. Nothing is automatically opened and a message is printed out

if open_mode == config.UIOpenMode.CHROME_OR_EDGE and chrome_available:
eel.start("index.html", size=(650, 672), port=0, mode="chrome")
elif open_mode == config.UIOpenMode.CHROME_OR_EDGE and edge_available:
eel.start("index.html", size=(650, 673), port=0, mode="edge")
elif open_mode == config.UIOpenMode.DEFAULT_BROWSER or (
open_mode == config.UIOpenMode.CHROME_OR_EDGE and not chrome_available and not edge_available
):
eel.start("index.html", size=(650, 672), port=0, mode="user default")
else:
port = utils.get_port()
print("Server starting at http://localhost:" + str(port) + "/index.html")
eel.start("index.html", host="localhost", port=port, mode=None, close_callback=lambda x, y: None)

For 1, something like,

The interface is being opened in a new Chrome window
Please do not close this terminal while using auto-py-to-exe - the process will end when the window is closed

For 2, something like,

The interface is being opened in a new Edge window
Please do not close this terminal while using auto-py-to-exe - the process will end when the window is closed

For 3, something like,

The interface is being opened in your default browser
Please do not close this terminal while using auto-py-to-exe - the process will end when the tab is closed

For 4, something like,

Server starting at http://localhost:{port}/index.html
You may end this process using Ctrl+C when finished using auto-py-to-exe

@brentvollebregt
Copy link
Owner

Just pushed to master - I'll get this out tomorrow if I get time.

@mcagriaksoy
Copy link
Contributor Author

wow it was fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants