Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requestrr - Change to tar.gz instead of zip #29

Open
thomst08 opened this issue Jun 26, 2024 · 2 comments
Open

Requestrr - Change to tar.gz instead of zip #29

thomst08 opened this issue Jun 26, 2024 · 2 comments

Comments

@thomst08
Copy link

Hello,

I currently maintain Requestrr, a user reached out today and was using one of your old scripts to setup Requestrr. I noticed when looking over the script it is downloading and extracting the zip files form GitHub, I am going to stop uploading those version going forward and only providing tar.gz files.

Just wanted to reach out and make the suggestion to update your script. These are the lines I picked up to help :)

dlurl="https://github.com/thomst08/requestrr/releases/download/${version}/requestrr-linux-${arch}.zip"

dlurl="https://github.com/thomst08/requestrr/releases/download/${version}/requestrr-linux-${arch}.tar.gz"

if ! curl "$dlurl" -L -o $HOME/.tmp/requestrr.zip >> "$log" 2>&1; then

if ! curl "$dlurl" -L -o $HOME/.tmp/requestrr.tar.gz >> "$log" 2>&1; then

hosted-scripts/requestrr.sh

Lines 224 to 225 in 68d18a3

unzip -q "$HOME/.tmp/requestrr.zip" -d $HOME/ >> ${log} 2>&1
rm -rf "$HOME/.tmp/requestrr.zip"

tar -xzf "$HOME/.tmp/requestrr.tar.gz" -C $HOME/ >> ${log} 2>&1
rm -rf "$HOME/.tmp/requestrr.tar.gz"
@thomst08
Copy link
Author

I also noticed a bug with your script, in the code you are configuring the appSettings.json file.
This is used to control where the config path is in the latest version ,because of the change it breaks the latest version and doesn't start.

hosted-scripts/requestrr.sh

Lines 209 to 217 in 68d18a3

cat > $HOME/Requestrr/appsettings.json << SET
{
"Logging": {
"LogLevel": {
"Default": "None"
}
},
"AllowedHosts": "*"
}

This is the correct file

{
  "Logging": {
    "LogLevel": {
      "Default": "Warning"
    }
  },
  "AllowedHosts": "*",
  "ConfigFolder": "./config"
}

@brettpetch
Copy link
Owner

Thanks. I’ll get a pr together this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants