Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barclay parser doesn't render embedded html as text in usage output #112

Open
cmnbroad opened this issue Nov 14, 2017 · 4 comments
Open

Comments

@cmnbroad
Copy link
Collaborator

cmnbroad commented Nov 14, 2017

LegacyCommandLineArgumentParser does some limited html tag/entity->text rendering when displaying command line help summary, but the CommandLineArgumentParser doesn't do this, but it should.

@magicDGS
Copy link
Contributor

@cmnbroad - this can be solved with the markdown support in #68, because markdown also supports html and the conversion to text will take care of html tags (as far as I remember). Maybe it is time to have a look to that PR adding mocking tests...

@vdauwera
Copy link

Let me know if you guys want me to look at anything; last time I checked everything looked good to me in terms of output, but you guys were discussing technicalities around testing, which I'm fairly agnostic on.

@cmnbroad
Copy link
Collaborator Author

@magicDGS @vdauwera I think this specific issue can be easily fixed pretty easily (at least so we achieve parity with the legacy parser) by just integrating the code the legacy parser uses. I'd love to get markdown in, but I don't realistically expect that will happen until after the GATK release.

@vdauwera
Copy link

Happy to follow your recommendation @cmnbroad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants