You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following free functions should consolidate into a class that deals with all MemoryBundle troubles. The lifetime of the said class attached with the translation model feels like a sensible thing to do. Anything further inside can use a reference or pointer to the said class.
Can we piggy back this: XapaJIaMnu/translateLocally#89
We should do a "best-effort" load strategy with some warnings if something is missing, rather than falling flat when we can deliver some user experience.
The following free functions should consolidate into a class that deals with all
MemoryBundle
troubles. The lifetime of the said class attached with the translation model feels like a sensible thing to do. Anything further inside can use a reference or pointer to the said class.bergamot-translator/src/translator/byte_array_util.h
Lines 7 to 16 in f6d9233
With this consolidation, we may also address
However, it will be easier to consolidate and take on the packaging and breaking changes in a second iteration.
The text was updated successfully, but these errors were encountered: