Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases for HTML/Non-HTML translation per item of Batch Translation API #363

Open
abhi-agg opened this issue Feb 28, 2022 · 2 comments
Open

Comments

@abhi-agg
Copy link
Contributor

filed because of #345 (comment) and #345 (comment).

@jerinphilip
Copy link
Contributor

Tests are missing in the JavaScript layer entirely. Note that C++ tests will not cover the JavaScript, and the sloppy development operation in JavaScript has led to configuration faults that have led to blame at the engine (mozilla/firefox-translations#51) despite getting it correct in #269, due to manual movement human error in place of continuous testing and integration.

I'm currently capturing possibilities in #330, but this is outside my assigned tasks - so it will have to come out of spare time.

I will also make an offer for WebAssembly devs to take ownership of https://github.com/browsermt/bergamot-translator/blob/main/src/tests/wasm.cpp and associated tests so WebAssembly requirements can be codified. Note that the tests I bring in are going to be c5cea4b (#346), and I'm waiting to get access to var or an avx512vnni machine again (cc @kpu).

@abhi-agg
Copy link
Contributor Author

@jerinphilip As you are not responsible for any JS/WASM work, please feel free to not do it. Nobody is asking you to do it.

The feature was added to the engine and it was a major API change. So C++ tests are kind of needed. There is no assignee on this issue. I created it so that we could close the original one (which unblocked the integration in extension) and not forget about tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants