Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python package seems broken #471

Open
bjesus opened this issue Apr 19, 2024 · 2 comments
Open

Python package seems broken #471

bjesus opened this issue Apr 19, 2024 · 2 comments

Comments

@bjesus
Copy link
Contributor

bjesus commented Apr 19, 2024

I can't seem to figure out how to use the python package, and I suspect it's broken.

❯ bergamot download

❯ bergamot ls
Available models:

It never seem to find any model or to let you download any model.

@bjesus
Copy link
Contributor Author

bjesus commented Apr 19, 2024

This fixes a bug with downloading: #472

@bunburya
Copy link

bunburya commented Sep 7, 2024

#474 is intended to fix another bug with downloading models.

#472 works well with the default browsermt repo but it has issues with the opus repo as files are named differently there. For example the eng-fin-tiny model has the filename eng-fin.transformer-tiny11.tar.gz. So removing everything after the third . gives you eng-fin.transformer-tiny11.tar which is not the name of the extracted directory. I'm not sure if there is any one-size-fits-all solution though, if different repos follow different file naming conventions for their models. Maybe there should be a separate Repository subclass for opus which defines different name-stripping logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants