Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.value() is sometimes left on the end of PropTypes for externally declared PropTypes #2

Open
erickakoyama opened this issue Feb 20, 2019 · 1 comment

Comments

@erickakoyama
Copy link

I'm not sure if this is worth adding a check for, but there were two cases where after conversion our prop declaration went from something like:

truncated: Config.bool().value(false)

to

truncated: PropTypes.bool.value(false)

These were both somewhat exceptional cases. Both instances were that we had defined a reusable prop shape outside of the actual component class. What do you think?

@erickakoyama erickakoyama changed the title .value() is sometimes left on the end of PropTypes .value() is sometimes left on the end of PropTypes for externally declared PropTypes Feb 20, 2019
@bryceosterhaus
Copy link
Owner

How many instances of this do you think occur for you? I'd probably say if its less than 5 or 10, just manually update those for now. If its more than that, I can update the transform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants