You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if this is worth adding a check for, but there were two cases where after conversion our prop declaration went from something like:
truncated: Config.bool().value(false)
to
truncated: PropTypes.bool.value(false)
These were both somewhat exceptional cases. Both instances were that we had defined a reusable prop shape outside of the actual component class. What do you think?
The text was updated successfully, but these errors were encountered:
erickakoyama
changed the title
.value() is sometimes left on the end of PropTypes
.value() is sometimes left on the end of PropTypes for externally declared PropTypes
Feb 20, 2019
How many instances of this do you think occur for you? I'd probably say if its less than 5 or 10, just manually update those for now. If its more than that, I can update the transform.
I'm not sure if this is worth adding a check for, but there were two cases where after conversion our prop declaration went from something like:
to
These were both somewhat exceptional cases. Both instances were that we had defined a reusable prop shape outside of the actual component class. What do you think?
The text was updated successfully, but these errors were encountered: