Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required confirmations for spendable policy should not be hardcoded #13

Open
jrick opened this issue Jan 8, 2016 · 0 comments
Open

Required confirmations for spendable policy should not be hardcoded #13

jrick opened this issue Jan 8, 2016 · 0 comments

Comments

@jrick
Copy link
Member

jrick commented Jan 8, 2016

Right now this is hardcoded as 1 block confirmation everywhere in the code. Instead, this should be user-selectable.

Some kind of settings view could be added that enables changing this option.

Changing this value should result in updating all of the spendable balances with the new required number of confs.

The largest value the required confirmations can be set to is 100 (the coinbase maturity value) since transactions mined after this many blocks are not guaranteed to be saved in memory by Paymetheus.
jrick added a commit to jrick/Paymetheus that referenced this issue Jun 29, 2016
@jrick
Hide the Border for the generated address unless one was generated.
4d714f4 
Simplify the UI by always showing the "generate address" button.
Click again to generate a new address, replacing the old.

Improve the xaml so it doesn't look like it got generated by 15
different automated tools.

Make the address manually selectable so it can be copied, since the
label under the address is lying and it is not automatically copied to
clipboard yet.

Fixes btcsuite#13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrick