Rename account dialog does not disable the rename button

[davecgh]

The rename account dialog does not disable the rename button and provide details on why it's disabled for invalid entries.

There are at least two cases of invalid input:

• Specifying the existing name of the account being renamed
• Specifying an existing name of any account

Under these scenarios the rename dialog lets you press the rename button repeatedly and nothing happens.

I would suggest a label be added to the dialog which is displayed on conditions which prevent entry and for the rename button to be disabled in said cases. So, for example, entering the same name as the existing account would disable the rename button and show a label "An account already exists with the specified name."

[jrick]

An error is currently caught and handled by being printed to console, but you wouldn't know unless you were running it in the visual studio debugger.

There is currently no RPC to query for whether a name is valid or not, and it would be a race condition if we added one to do that check (consider duplicate names).

I agree that there should be an error message displayed to the user through the GUI somehow.

[davecgh]

It should be pretty easy to check against the list of known accounts in the accounts list, right?

I realize this wouldn't catch the case of an account being created by another process, but that is unlikely to happen very often in practice and simply checking against the known accounts client side (within Paymetheus) will improve the UX for almost all realistic cases.

[jrick]

Sure, that's a good idea.