feature request: javascript/typescript support

[glerchundi]

Are you open for a PR supporting javascript/typescript?

[rodaine]

Totally!

[4nte]

@glerchundi Are you planning to work on this?

[glerchundi]

@AnteGulin probably in January but we need to first discuss the approach of course:

• Only pure javascript?
• Typescript is typically used in an Angular application which usually per-property validations were better than a one and only Validate method.
• Maybe include this per-property in pure javascript and then type definitions on those?
• What to do with RE2 validations? TypeError: Couldn't build proto file into descriptor pool! protocolbuffers/protobuf#53

And probably much more question, any thoughts?

[glerchundi]

/cc @aberasarte

[NeoCN]

any update on this ?

[rodaine]

Only pure javascript?

I think pure JS with TS stubs is the way to go, if that makes sense.

Typescript is typically used in an Angular application which usually per-property validations were better than a one and only Validate method. Maybe include this per-property in pure javascript and then type definitions on those?

For consistency with the rest of the languages, a single validate is preferred. While some of these implementations fail fast, if desired the function can gather all violations into a single error for per-property introspection. That said, if you want to go beyond that and provide per-property, I think that's fine too.

What to do with RE2 validations? protocolbuffers/protobuf#53

This isn't implemented yet, and is meant for validating that the value of a field is a valid regex, not that the value matches a regex. I'd not worry about this at the moment.

[Shivam010]

@glerchundi @rodaine
Any update on this?
If any help is needed I am open for this...

[glerchundi]

As we want to have a full closed loop for the js code generation as well as the validation part of it, we're blocked on this: protocolbuffers/protobuf-javascript#65.

I think this can workaround by doing some seding after protoc, although it is a really awful solution :)

[Shivam010]

Ok then...

[smorel-plenty]

Gently pining this ticket. Is it truly blocked on protocolbuffers/protobuf-javascript#65 it's hard to tell if that one is ever going to get fixed. Would it be possible to make some progress on this feature with the assumption that there are caveats (e.g. non-separability of the generated code modules)? Maybe even support by targeting another proto JS or TS generator?

[buzzdan]

Watching..

[buzzdan]

@glerchundi do you think theres any way around protocolbuffers/protobuf-javascript#65 ?

[thesayyn]

Gently pining this ticket. Is it truly blocked on protocolbuffers/protobuf-javascript#65 it's hard to tell if that one is ever going to get fixed. Would it be possible to make some progress on this feature with the assumption that there are caveats (e.g. non-separability of the generated code modules)? Maybe even support by targeting another proto JS or TS generator?

We can target the one that we created. We have the ability to iterate quicker than any other plugin out there. I am ready to implement the validation runtime here and get it working with https://github.com/thesayyn/protoc-gen-ts

The only thing that I need right now, a runtime implemented here.

thesayyn/protoc-gen-ts#65

[loeffel-io]

Would love to see a js/ts implementation

[buzzdan]

@thesayyn any updates on this one ?

[derekperkins]

For anyone interested, this project (not mine), maps protoc-gen-validate grammar to an Open API spec, which then generates validation code. It's not perfect, but at least an option for anyone waiting on this to be resolved.
https://github.com/kollalabs/protoc-gen-openapi

[nickwinger]

actually i thought that buf (and connect-web) is primarly here to make the perfect support for web/java/typescriprt and grpc. Now i wonder why we don't have validation and a language such as go ?!? is preferred ?

[SpareShade]

just for reference connectrpc/connect-es#270

[elliotmjackson]

Thanks for your feature request for TypeScript support. We appreciate your interest in enhancing the usability of pgv.

I wanted to let you know that we're actively working on adding TypeScript support in the protovalidate project. While this won't be implemented in protoc-gen-validate, we're excited about the possibilities it will bring to the Protobuf ecosystem.

With that said, I'll be closing this issue as we're addressing it in the protovalidate repository. If you have any more suggestions or questions, feel free to drop them our way.