Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI --enable_platform_specific_config improvements #7517

Open
siggisim opened this issue Sep 20, 2024 · 0 comments
Open

CLI --enable_platform_specific_config improvements #7517

siggisim opened this issue Sep 20, 2024 · 0 comments

Comments

@siggisim
Copy link
Member

siggisim commented Sep 20, 2024

Looks like we added support for --enable_platform_specific_config to the CLI in this PR: cbdb3e5

CLI behavior seems to differ from Bazel in a couple of cases:

  1. If you pass --enable_platform_specific_config with no arg - that enabled the functionality in Bazel land, but not in CLI land. I suspect that's due to this logic here:

    if enable == "true" || enable == "yes" || enable == "1" || enable == "" {

  2. If you enable platform specific config for common

common --enable_platform_specific_config=yes

But only have a config set for build

build:linux --foo
build:macos --bar

And you run a

bazel query //...

You get

ERROR: Config value 'linux' is not defined in any .rc file

Which is because we tack on

bazel query //... --config=linux

Which doesn't quite match Bazel's behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant