Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated section about one-to-many relations between viewpoints and comments #347

Open
GeorgDangl opened this issue Jun 22, 2021 · 1 comment

Comments

@GeorgDangl
Copy link
Member

This section in the documentation is outdated: https://github.com/buildingSMART/BCF-XML/tree/release_3_0/Documentation#one-to-many-mapping-between-viewpoints-and-comments

In the schema, we have this for the comment:
https://github.com/buildingSMART/BCF-XML/blob/release_3_0/Schemas/markup.xsd#L153-L167

Which means that a single comment may refer either one or zero viewpoints.

For the viewpoints, there is no longer a way to link them to a specific comment. So looks like we can drop this.

Originally raised by @pasi-paasiala in Slack.

@GeorgDangl
Copy link
Member Author

We'll just remove this part completely:

One to Many Mapping between Viewpoints and Comments
The schema would allow to have many to many mapping between viewpoints and comments. This is not allowed. A viewpoint can have multiple comments, but a comment can only refer to one viewpoint.

@GeorgDangl GeorgDangl self-assigned this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant