Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: control max-depth for directory traversal #1810

Open
2 tasks done
shahzebsiddiqui opened this issue Aug 16, 2024 · 0 comments
Open
2 tasks done

[FEATURE]: control max-depth for directory traversal #1810

shahzebsiddiqui opened this issue Aug 16, 2024 · 0 comments
Assignees

Comments

@shahzebsiddiqui
Copy link
Member

Please describe your feature

Similar to #1809 we should have a configurable option on command line such as --max-depth and configuration value max-depth that can control the level of directories to traverse when using the walk_tree method, by default max_depth=None is set which will traverse entire directory tree

def walk_tree(
root_dir,
ext=None,
max_depth=None,
numfiles=None,
file_traverse_limit=999999,
file_type="file",
):

I think this feature would be useful when one wants to traverse level 1 which is only files within a directory and not all sub-directories.

This feature would be useful let's say one wants to build all buildspecs in tutorials/*.yml and user just does buildtest --max-depth=1 bd -b tutorials/

Suggest potential solution

The configuration value would be defined as follows

system:
  generic:
     max-depth: 1

Note that if its defined in configuration this will be the default behavior and one would either update or remove the value if they want the default behavior or set it on the command line.

The max-depth must be an integer and >=0

Additional Information

No response

Post question in Slack

  • I agree that I posted my question in slack before creating this issue

Is there an existing issue

  • I confirm there is no existing issue for this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants