-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABI issue with go1.22 #820
Comments
Interesting to know that someone made a homebrew package. |
why not? what is the concern? |
There is no concern I just didn't know. |
In early December, a new internal package linknamed from runtime was introduced, internal/chacha8rand. Re-generate the tables. Note that due to the same group of CLs and refactors, math/rand and net are no longer linknamed from runtime in Go 1.22. They are still in Go 1.21, so keep those entries around for now. We can remove math/rand/v2, as it doesn't yet exist in 1.21. Fixes burrowers#820.
In early December, a new internal package linknamed from runtime was introduced, internal/chacha8rand. Re-generate the tables. Note that due to the same group of CLs and refactors, math/rand and net are no longer linknamed from runtime in Go 1.22. They are still in Go 1.21, so keep those entries around for now. We can remove math/rand/v2, as it doesn't yet exist in 1.21. Fixes #820.
Cool cool, thanks for the quick fix! |
Tnx for the fix, but to get it to homebrew this still needs to be tagged / released in the 0.12.0 or higher sometime before Go 1.22.0 is released (scheduled for February). |
We did a release just three weeks ago. We can do another in a few weeks. If you're packaging a Go pre-release, you can package garble master. |
Go 1.22 is scheduled to be released in February, so few weeks from now should still be ok. |
@mvdan Go 1.22 is released |
See #828. We uncovered a GOOS=darwin bug with Go 1.22, hence a slight delay with the release. |
What version of Garble and Go are you using?
latest garble
go 1.22rc1
What environment are you running Garble on?
happens on all environments, see this action run, https://github.com/chenrui333/garble/actions/runs/7280828786/job/19840079094
What did you do?
setup go 1.22rc1 and run
go test --race -timeout=20m ./...
What did you expect to see?
pass the tests
What did you see instead?
tests failed
relates to Homebrew/homebrew-core#157782
The text was updated successfully, but these errors were encountered: