Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurelia 2 #28

Open
elitastic opened this issue Mar 9, 2023 · 9 comments
Open

Aurelia 2 #28

elitastic opened this issue Mar 9, 2023 · 9 comments

Comments

@elitastic
Copy link
Contributor

As Aurelia 2 is in beta now, are there any plans to support Aurelia 2?

Thanks for a short feedback.

@3cp
Copy link
Member

3cp commented Mar 9, 2023

3cp/aurelia2-dnd#2

I need to get back to it.

Aurelia 2 has this sync mode of change notification which causes issue of state tearing.

@bigopon
Copy link

bigopon commented Mar 9, 2023

Aurelia 2 has this sync mode of change notification which causes issue of state tearing.

Instead of spreading state across multiple fields, maybe group them all into a single object? if they need together, maybe we need to group them together?

@3cp
Copy link
Member

3cp commented Mar 9, 2023

I can use the batch api if it's available.

@3cp
Copy link
Member

3cp commented Mar 10, 2023

This issue is resolvable here because this is an aurelia plugin.

For some other js lib out of aurelia landscape, aurelia 1 can observe any POJO change without any problem. But aurelia 2 might have trouble, user might need to wrap it behind batch api in user's app code. This is main worry I had about aurelia 2's sync observing.

@elitastic
Copy link
Contributor Author

What do you guys think, does anyone find time to take a look at this in the near future?

@3cp
Copy link
Member

3cp commented Jun 13, 2023

@bigopon is the batch API ready yet?

@bigopon
Copy link

bigopon commented Jun 13, 2023

@3cp it is for both normal and collection

@3cp
Copy link
Member

3cp commented Jun 13, 2023

Thx, I will have a look.

@3cp
Copy link
Member

3cp commented Jul 27, 2023

Batch api worked well in https://github.com/3cp/aurelia2-dnd v0.3.0.

Aurelia 2's reorderable-repeat will take some work as the repeater in Aurelia 2 is totally different from Aurelia v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants