Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listview is deprecated #111

Closed
myunusss opened this issue Nov 7, 2018 · 13 comments
Closed

Listview is deprecated #111

myunusss opened this issue Nov 7, 2018 · 13 comments

Comments

@myunusss
Copy link

myunusss commented Nov 7, 2018

everything works fine 👍, but give me a warning like this :

" ListView is deprecated and will be removed in a future release. "

is it possible to replace with FlatList ?

thank you

@amrita019
Copy link

@myunusss Any update on this?

@kristoferpelchat
Copy link

@mrlaessig Hi :) Do you plan on moving to FlatList above as @myunusss suggests? I would hate to see ListView go away and this AWESOME library is still using it. Thoughts?

@msqar
Copy link

msqar commented Feb 25, 2019

Damn i was hoping for this to be solved. I want this to be migrated to FlatList too... i might create a PR for this, though.

@Javier-Rotelli
Copy link
Collaborator

welp, there are at least 2 PR's fixing this (#65 and #83) =/
but no answer from @mrlaessig

@ConnectedReasoning
Copy link

anybody want to fork this?

@Javier-Rotelli
Copy link
Collaborator

hi @ConnectedReasoning, I'm intending to maintain this repo. however as soon as i got permissions, life appeared. i'll be merging PR's and doing housekeeping on the weekend

@ConnectedReasoning
Copy link

@Javier-Rotelli Thats awesome, thanks. I'll keep a lookout and can help you test. I was looking over your changes and so far so good. Looks like users need to provide a couple more props?

@ConnectedReasoning
Copy link

@Javier-Rotelli this is an example of a good react autocomplete implementation. React Materialize Autocomplete

I would like to see our react-native component here implement these features and behaviors minus the materialize specifics of course. Let me know what you think.

@ConnectedReasoning
Copy link

Happy to see the updates! I will try them out in my app today

@ConnectedReasoning
Copy link

Ok, npm install brought in the old version. Maybe something has to be updated at npm? I copied and pasted the index.js into my node modules and I am no longer getting the listview error

@Javier-Rotelli
Copy link
Collaborator

Hi @ConnectedReasoning good to hear that, i didn't made the release yet.
it worked without changing anything on your code?. I haven't had the time to test this properly, and i don't want to ship breaking changes on a minor or patch release

@ConnectedReasoning
Copy link

ConnectedReasoning commented Apr 9, 2019

I had removed autocomplete from my code as it was giving me the warnings. I did not have to change anything out of the ordinary to get this to work after I copied and pasted the latest index.js to my node_modules auto complete installation. I was even able to apply typeahead filtering within my own code. GithubGist Incidentally we may want to document that onFocus is a property event exposed by Autocomplete.

@Javier-Rotelli
Copy link
Collaborator

Fixed on #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants