Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustix::fs::OFlags::Async is missing #1243

Closed
yuki0iq opened this issue Dec 16, 2024 · 0 comments · Fixed by #1312
Closed

rustix::fs::OFlags::Async is missing #1243

yuki0iq opened this issue Dec 16, 2024 · 0 comments · Fixed by #1312
Labels
enhancement New feature or request

Comments

@yuki0iq
Copy link
Contributor

yuki0iq commented Dec 16, 2024

linux-raw-sys defines FASYNC instead of O_ASYNC linux-raw-sys/.../general.rs

The Linux header file <asm/fcntl.h> doesn't define O_ASYNC; the (BSD-derived) FASYNC synonym is defined instead.
(man 2 open)

Note that O_ASYNC can't be used for open(2), so this should probably be noted if Async is ever added to OFlags
@sunfishcode sunfishcode added the enhancement New feature or request label Dec 18, 2024
yuki0iq added a commit to yuki0iq/rustix that referenced this issue Feb 6, 2025
@yuki0iq
Add O_ASYNC/FASYNC to OFlags
9b16158 
Closes bytecodealliance#1243
yuki0iq added a commit to yuki0iq/rustix that referenced this issue Feb 6, 2025
@yuki0iq
Add O_ASYNC/FASYNC to OFlags
3255882 
Closes bytecodealliance#1243
yuki0iq added a commit to yuki0iq/rustix that referenced this issue Feb 6, 2025
@yuki0iq
Add O_ASYNC/FASYNC to OFlags
722d378 
Closes bytecodealliance#1243
yuki0iq added a commit to yuki0iq/rustix that referenced this issue Feb 6, 2025
@yuki0iq
Add O_ASYNC/FASYNC to OFlags
645374a 
Closes bytecodealliance#1243
yuki0iq added a commit to yuki0iq/rustix that referenced this issue Feb 6, 2025
@yuki0iq
Add O_ASYNC/FASYNC to OFlags
a2e14ff 
Closes bytecodealliance#1243
yuki0iq added a commit to yuki0iq/rustix that referenced this issue Feb 6, 2025
@yuki0iq
Add O_ASYNC/FASYNC to OFlags
b75fc68 
Closes bytecodealliance#1243
@yuki0iq yuki0iq mentioned this issue Feb 6, 2025
Merged
yuki0iq added a commit to yuki0iq/rustix that referenced this issue Feb 6, 2025
@yuki0iq
Add O_ASYNC/FASYNC to OFlags
239e851 
Closes bytecodealliance#1243
sunfishcode pushed a commit that referenced this issue Feb 6, 2025
@yuki0iq
Add O_ASYNC/FASYNC to OFlags (#1312)
3ae4069 
Closes #1243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add O_ASYNC/FASYNC to OFlags yuki0iq/rustix
2 participants
@sunfishcode @yuki0iq