Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.2 #2

Closed
antonkulaga opened this issue May 28, 2016 · 4 comments
Closed

update to 1.2 #2

antonkulaga opened this issue May 28, 2016 · 4 comments

Comments

@antonkulaga
Copy link

Please, update preset loading to 1.2 (it is 1.1 right now)

@lloydmeta
Copy link
Member

Hi there, I'll release a new version of this plugin with a version bump to 1.2 soon (currently on vacation), but until then, you can use javaCVVersion := "1.2"(declared here) in your Build.scala/build.sbt to set it manually :)

@saudet
Copy link
Member

saudet commented May 29, 2016 via email

@lloydmeta
Copy link
Member

That is something you can definitely do in SBT, but I think it needs a bit more thought and likely should not be the default behaviour:

  1. it assumes the ability to connect to Maven Central for the query
  2. should probably have a fallback to a default version if querying fails
  3. assumes that the user is ok with arbitrarily using the latest version, which can cause major compilation or runtime issues

For me, 3. is the biggest reason for not making this the default behaviour. That said, I'll leave a ticket open because it is a good idea (#3)

@lloydmeta
Copy link
Member

I've just released a new version of this plugin that defaults to 1.2, so I'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants