Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to scroll #10

Open
ronaldohoch opened this issue Mar 22, 2018 · 3 comments
Open

Add possibility to scroll #10

ronaldohoch opened this issue Mar 22, 2018 · 3 comments
Assignees

Comments

@ronaldohoch
Copy link

First of all: AWESOME TOOL!

Can you add the feature to scroll x pixels or scroll to #id?

@c0bra c0bra self-assigned this Mar 22, 2018
@c0bra
Copy link
Owner

c0bra commented Mar 22, 2018

Thanks!

Internally, deviceframe uses screenshot-stream, which has a selector option. We can add an option for that and pass it a long.

Do you have an example page you'd want to test?

@c0bra c0bra added this to the 1.1.0 milestone Mar 22, 2018
@ronaldohoch
Copy link
Author

I think You can test in my last website Imperium LARP

image

The "first page" always have the device height and content is after.

@c0bra
Copy link
Owner

c0bra commented Mar 28, 2018

So the selector option actually just clips the selector you pass as the screenshot.

There's no way to scroll currently AFAICT. I'll see about opening a pull request.

@c0bra c0bra removed this from the 1.1.0 milestone Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants