Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

construct a label from other benchmark fields #3

Open
cwpearson opened this issue Aug 13, 2018 · 6 comments
Open

construct a label from other benchmark fields #3

cwpearson opened this issue Aug 13, 2018 · 6 comments
Assignees

Comments

@cwpearson
Copy link
Member

No description provided.

@abduld
Copy link

abduld commented Aug 13, 2018

@cwpearson
Copy link
Member Author

Can you add a snippet of the benchmark.json file as well?

@abduld
Copy link

abduld commented Aug 13, 2018

e.g.

 {
      "name": "SGEMM/384/169/1",
      "iterations": 13074,
      "real_time": 5.3525743996501726e+04,
      "cpu_time": 5.3539960532357516e+04,
      "time_unit": "ns",
      "K": 1.0000000000000000e+00,
      "M": 3.8400000000000000e+02,
      "N": 1.6900000000000000e+02
    }, 

https://github.com/rai-project/scope/blob/master/results/raw_data/minsky/sgemm_smt_0.json

@cwpearson
Copy link
Member Author

cwpearson commented Aug 16, 2018

What about something like this. This would construct a string with the specified seperator, from the fields in each benchmark object

In the spec file

label:
  seperator: "x" # optional, there would be some default
  fields:
  -  K
  -  M
  -  N

or for command line utilities

... --label-seperator x --label-fields K M N ...

The result for the offered snippet would be

1x384x169

@cwpearson
Copy link
Member Author

Some more thoughts.
In the spec file, at the series level, series.label is the name of the series in the plot legend right now, so perhaps add another two optional fields series.tick_fields and series.tick_seperator

series:
  - ...
    tick_seperator: "x" # optional, there would be some default
    tick_fields: [K, M, N]
  - ...

or for command line utilities

... --tick-seperator x --tick-fields K M N ...

The result for the offered snippet would be

1x384x169

There will need to be some changes in how dataframes are generated in scope_plot/benchmark.py and consumed in the generate_bar() portions of scope_plot/backends/....
I think when the dataframe is generated, the index of the dataframe should be set to the desired tick label.
Then, when that dataframe is consumed the logic would need to be adjusted a bit to plot it correctly.

@cwpearson
Copy link
Member Author

Added support for series.tick_fields and series.tick_seperator in schema.py, but no logic to actually use them.

bc739ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants