Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX (?) bug: ugly error if you don't have access to see collaborators on a repo #19

Open
antislice opened this issue Jun 12, 2016 · 0 comments

Comments

@antislice
Copy link
Collaborator

antislice commented Jun 12, 2016

Stems from what I saw on #18. Github returns a 403 error if you don't have push access: GET https://api.github.com/repos/calagator/calagator/collaborators?per_page=100: 403 - Must have push access to view repository collaborators. (for example)

Fix would probably be to catch that error & not save collaborator info when creating Contributors. Or checking on the permissions of the person running osbot up front & not even making that call to github to get the collaborators. Then someone would just see the list of usernames with scores.

Or, the decision could be made to only have any of the app function if you at least have push access, in which case a nice apologetic error message before trying to load anything would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant