Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #120

Open
cachapa opened this issue Aug 9, 2023 · 2 comments · May be fixed by #140
Open

Add documentation #120

cachapa opened this issue Aug 9, 2023 · 2 comments · May be fixed by #140

Comments

@cachapa
Copy link
Owner

cachapa commented Aug 9, 2023

Add documentation to most, or all public methods and fields using the /// comment notation, e.g.:

/// Add [x] to [y] and return the result
int add(int x, int y) {
  return x + y;
}

It would be nice to document at least 20% of the public API to satisfy pub.dev score.

The challenge is to find a way for pub.dev to ignore the generated code, or to change the way code generation works so it's no longer part of the Firedart SDK.

Ideally, doing the above will also organize the pub.dev API documentation which currently is essentially unusable.

@cachapa cachapa mentioned this issue Aug 9, 2023
@nickmeinhold
Copy link

When I run pana locally I get:

702 out of 2214 API elements (31.7 %) have documentation comments.

and 160/160 points.

I'd be happy to add some basic documentation to the public API if you still want this but thought I would check first given pana is happy.

@cachapa
Copy link
Owner Author

cachapa commented Jun 19, 2024

I would appreciate that. As described above, one of the issues is that the generated code represents a large part of this project and I'm not sure if there's a way to tell the tooling to ignore that (maybe it's already doing that?).

In any case documenting our public API is always welcome.

@nickmeinhold nickmeinhold linked a pull request Jun 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants