Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parameter checks and error messages before running a simulation #28

Open
3 tasks
schmoelder opened this issue Mar 10, 2020 · 1 comment · May be fixed by #109
Open
3 tasks

Improve parameter checks and error messages before running a simulation #28

schmoelder opened this issue Mar 10, 2020 · 1 comment · May be fixed by #109

Comments

@schmoelder
Copy link
Contributor

schmoelder commented Mar 10, 2020

Before running a simulation, parameters could be checked for sanity (e.g. correct sizes and plausible values).

Furthermore, after the simulation, simulation results could be checked (e.g., mass balance checks out).

Tools like this could be implemented in CADET-core or in higher level tools like CADET-Process

List of known issues:

@schmoelder schmoelder changed the title Implement linting tool Improve parameter checks and error messages before running a simulation Nov 17, 2021
@schmoelder schmoelder linked a pull request Jan 18, 2022 that will close this issue
@jazib-hassan-juelich
Copy link
Contributor

jazib-hassan-juelich commented Feb 9, 2022

Before running a simulation, following check should be included:

  • check the conistency between the last entries in the root.input.solver.sections.section_times and root.input.solver.user_solution_times. Any inconsistency between these two values can result in a failing simulation.

This should be included in the CADET core

@jazib-hassan-juelich jazib-hassan-juelich pinned this issue Feb 9, 2022
@lieres lieres unpinned this issue Mar 23, 2023
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 14, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 15, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 17, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 18, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 18, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 29, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 29, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 29, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 1, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 4, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 4, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 4, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 4, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 7, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 7, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 7, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 7, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 9, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 9, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Oct 16, 2023
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants