Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang-format for formatting code #99

Open
sleweke opened this issue Aug 10, 2021 · 2 comments · May be fixed by #148
Open

Use clang-format for formatting code #99

sleweke opened this issue Aug 10, 2021 · 2 comments · May be fixed by #148

Comments

@sleweke
Copy link
Contributor

sleweke commented Aug 10, 2021

Decide on a code formatting and write a clang-format description. This establishes clear formatting guidelines that can be applied as pre-commit hook. Also saves a lot of noise in the code reviews (e.g., formatting comments).

@schmoelder
Copy link
Contributor

schmoelder commented Sep 20, 2021

@jayghoshter Can I assign you to do this together with @Immudzen!?

@jbreue16
Copy link
Contributor

We have decided to postpone this until some legacy branches are merged.
For new branches/PRs we stick to our new dogma of smaller PR's and fast, functional merges which will make it easier to rebase those once we merge this PR.

Hopefully we can merge this for version 5.1 (crystallization)

These are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants