Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more service providers #1

Open
whoogle opened this issue Apr 13, 2021 · 3 comments
Open

Add support for more service providers #1

whoogle opened this issue Apr 13, 2021 · 3 comments

Comments

@whoogle
Copy link

whoogle commented Apr 13, 2021

Can you please add support for more music providers like Bandcamp, deezer, JioSaavn.

I think adding Bandcamp support is easy by adding it in regex entries of py file.

For deezer & saavn support you can use external public api available at
domain thearq.tech OR at http://35.240.133.234:8000

I hope soon improvements will be made.
Thanks

@dashezup
Copy link
Collaborator

No.

  • Bandcamp is supposed to be used as a music store, the music streaming feature is supposed to be only for preview. I rarely use it and rarely see people share bandcamp links
  • account or token is required to get full songs from Deezer, Jio Saavan requires an Indian IP to get more entries in search results. also, I don't like to rely on third-party API services, it increases the risk of broke that way.
  • there are already some bots for downloading and sending audio from deezer and jiosaavn, those already do things properly, try to find and use them.

This project is a Heroku adoption of the music plugin of my tgbot project, the main purpose of this project is provide support for easy deployment on Heroku.
Even if those features could be added, it should be added as a smart plugin to somewhere like tgbot project, it's easier to maintain the code that way.

@whoogle
Copy link
Author

whoogle commented Apr 24, 2021

@dashezup I found that deezer songs can be fetched directly from its official server using an ARL Token of user account. Using that token in Env variables we can fetch songs. all user need is an account on deezer.

@dashezup
Copy link
Collaborator

  • I know but the token is only available for a while (a few weeks or months maybe). I don't like that the user need to change it every once in a while and restart the bot. there are workarounds but I don't want to implement that in a public project.
  • you need to get the link. there are not much deezer users and it's not easy to get the URL without sharing from their app. I know that I can search with the deezer public api, but how would the user select the result? it could work by just automatically select the first result but it's better and more proper to be done through inline. and there are already bots which you can use by search and send audio in inline.

dashezup pushed a commit that referenced this issue May 23, 2022
* make script working for latest Pyrogram and Pillow

* specify versions in requirements.txt

* add Dockerfile and docker-compose.yml

* add newlines to end of files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants