Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component for Tabs as per Material design 3 standards #3590

Closed
shirodkarpushkar opened this issue Jan 11, 2023 · 8 comments
Closed

Add component for Tabs as per Material design 3 standards #3590

shirodkarpushkar opened this issue Jan 11, 2023 · 8 comments

Comments

@shirodkarpushkar
Copy link

A lot of existing packages are present for top material tabs but none of them follow updated material design 3 standards.

Since react native paper has almost all components as per material design 3, the tabs would be a missing piece and it would complete all the material 3 components.

I would request the development team to please add material top tabs as per material standards present in https://m3.material.io/components/tabs/overview.

Best Regards,
Pushkar

@lukewalczak
Copy link
Member

lukewalczak commented Jan 11, 2023

Hey @shirodkarpushkar, there is a dedicated library for top tabs called react-native-tab-view and as far as I remember they were planning to adjust it to the Material You.

@iM-GeeKy
Copy link

@shirodkarpushkar I've sort of been tracking this internally and as it stands these were the most relevant links I could find for material you tabs.

satya164/react-native-tab-view#1399
https://react-navigation.canny.io/feature-requests/p/implement-material-design-3

It doesn't seem like it's actively being worked on and might be a while before it gets implemented. You can potentially create an issue on their repo, but they might direct you to the feature request link above.

@lukewalczak
Copy link
Member

Currently, I'm closing the issue, however, if it will turn out that we are going to somehow cooperate with library authors and we will move tabs into Paper, you will be definitely notified.

@RichardLindhout
Copy link
Contributor

PR is welcome with Material You at https://github.com/web-ridge/react-native-paper-tabs!

@okwasniewski
Copy link
Member

Hey @shirodkarpushkar, @lukewalczak

Tab view has been moved to react navigation repository. Im definitely planning to add Material You design. It's hard to say exactly when but it is on the roadmap (Probably first half of this year).

https://github.com/react-navigation/react-navigation/tree/main/packages/react-native-tab-view

@tibbe
Copy link

tibbe commented Dec 15, 2023

@okwasniewski any updates on this?

@tibbe
Copy link

tibbe commented Jan 9, 2024

I think we should reopen this issue. There's still no MD3 implementation:

  • react-navigation doesn't seem to be moving in this direction and
  • react-native-paper-tabs doesn't work with react-navigation, as it doesn't use the Screen concept for its tabs.

I think if react-native-paper had a component, similar to how Appbar works, that could be passed as the tabBar component of the react-navigation material top tabs navigator that would be the best solution. It's hard for react-navigation to implement MD3 as it can't really rely on all the react-native-paper components that would be helpful for doing so.

@fabriziocucci
Copy link
Contributor

@okwasniewski / @lukewalczak

Would it make sense to re-open this? Or what's the latest on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants