Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support expressions starting with the hash-tag character #1095

Open
JanSzkandera opened this issue Jan 3, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@JanSzkandera
Copy link

JanSzkandera commented Jan 3, 2025

Is your feature request related to a problem? Please describe.

Currently, only the dollar sign JUEL expressions are supported by the converter, if useDelegateExpressionAsJobType is set to true.

Also the strings starting with a hash-tag are valid JUEL expressions.

Describe the solution you'd like

Support hash tag in the AbstractDelegateImplementationVisitor#L15.

The pattern should be like this

public static final Pattern DELEGATE_NAME_EXTRACT = Pattern.compile("[$#]\\{(.*)\\}");

Describe alternatives you've considered

  • Maybe pass the pattern as a configuration property?
  • Implement my own visitor instead.

Additional context

None.

@JanSzkandera JanSzkandera added the enhancement New feature or request label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant