Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move get_value_descriptions_from_cadsr() out of GdcImporter #134

Open
joeflack4 opened this issue Dec 1, 2021 · 0 comments
Open
Assignees
Labels
ease:high update Enhancement / update for an existing feature. urgency:low

Comments

@joeflack4
Copy link
Collaborator

joeflack4 commented Dec 1, 2021

Description

There's nothing about this function that is specific to GDC. In fact, PDC even uses it. It ought to be moved to another class, probably more likely, module.

Additional info

Important considerations before making this change

Upon examination in the debugger, I'm seeing that there were no values returned form this for any attributes in PDC. All of them returned None. I'm wondering if this is (a) a mistake and this should not have been used in the first place, or (b) not a mistake, and something missing on the server end; maybe somewhere that Harold and Dazhi left off. Perhaps the relevant values for PDC data was intended to be imported into the hot ecosystem FHIR server?

@joeflack4 joeflack4 self-assigned this Dec 1, 2021
@joeflack4 joeflack4 added update Enhancement / update for an existing feature. ease:high urgency:low labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ease:high update Enhancement / update for an existing feature. urgency:low
Projects
None yet
Development

No branches or pull requests

1 participant