From 78d1235e51025e97438dff8d3fdc4fe10c617675 Mon Sep 17 00:00:00 2001 From: Vijay Gojiya Date: Fri, 16 Feb 2024 23:44:55 +0530 Subject: [PATCH] fix: match android native method name same as IOS --- .../java/com/candlefinance/push/PushModule.kt | 13 +++---------- example/src/App.tsx | 13 ------------- src/index.tsx | 15 +-------------- 3 files changed, 4 insertions(+), 37 deletions(-) diff --git a/android/src/main/java/com/candlefinance/push/PushModule.kt b/android/src/main/java/com/candlefinance/push/PushModule.kt index a7d3b2a..3132944 100644 --- a/android/src/main/java/com/candlefinance/push/PushModule.kt +++ b/android/src/main/java/com/candlefinance/push/PushModule.kt @@ -22,12 +22,6 @@ class PushModule(reactContext: ReactApplicationContext) : return NAME } - // Example method - // See https://reactnative.dev/docs/native-modules-android - @ReactMethod - fun multiply(a: Double, b: Double, promise: Promise) { - promise.resolve(a * b) - } @@ -50,8 +44,8 @@ class PushModule(reactContext: ReactApplicationContext) : val listener = PermissionListener { requestCode: Int, _: Array, grantResults: IntArray -> if (requestCode == currentRequestCode) { - val permissionStatus = if (grantResults.isNotEmpty()) grantResults[0] else PackageManager.PERMISSION_DENIED - promise.resolve(permissionStatus== PackageManager.PERMISSION_GRANTED) + val isPermissionGranted = grantResults.isNotEmpty() && grantResults[0] == PackageManager.PERMISSION_GRANTED + promise.resolve(isPermissionGranted) return@PermissionListener true } return@PermissionListener false @@ -70,7 +64,7 @@ class PushModule(reactContext: ReactApplicationContext) : } @ReactMethod - fun getToken(promise: Promise) { + fun registerForToken(promise: Promise) { FirebaseMessaging.getInstance().token.addOnCompleteListener(OnCompleteListener { task -> if (!task.isSuccessful) { Log.w("getTokenError", "Fetching FCM registration token failed", task.exception) @@ -78,7 +72,6 @@ class PushModule(reactContext: ReactApplicationContext) : return@OnCompleteListener } - // Get new FCM registration token val token = task.result promise.resolve(token) }) diff --git a/example/src/App.tsx b/example/src/App.tsx index 6a6f881..36a2101 100644 --- a/example/src/App.tsx +++ b/example/src/App.tsx @@ -70,19 +70,6 @@ export default function App() { title="Register for Token" onPress={() => push.registerForToken()} /> -