-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DefineMap.prototoype.get() excludes non-serializable props #100
Comments
A virtual "getter" property like: fullName: {
get: function(){
return this.first + " " + this.last;
}
}
|
This JSBin shows the difference: http://jsbin.com/semojes/1/edit?js,console
In my opinion, it's time we add an |
This is not the right jsbin, isn't it? |
@pYr0x updated |
Assuming DefineMap.prototype.get() was intended to perform similarly to can.Map.prototype.attr(), then it should return a PJSO with the values of all enumerable props assigned. Instead, it is only returning all serializable props, essentially making this call signature identically to DefineMap.prototype.serialize().
See #99
The text was updated successfully, but these errors were encountered: