Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#each isIterable case not being hit #67

Closed
phillipskevin opened this issue Aug 29, 2017 · 1 comment
Closed

#each isIterable case not being hit #67

phillipskevin opened this issue Aug 29, 2017 · 1 comment

Comments

@phillipskevin
Copy link
Contributor

@garrettreed commented on Fri Sep 16 2016

The isIterable case within the each helper is not being hit by any of the current tests. That scenario would cause isIterable to be true within this helper?

@justinbmeyer brought this while working on #62. We expected a can.Map to match this case.


@matthewp commented on Fri Sep 30 2016

can-maps are not iterable currently. They would have to implement the iterable API like can-define does here: https://github.com/canjs/can-define/blob/master/can-define.js#L107-L109


@christopherjbaker commented on Fri Mar 31 2017

Solved by canjs/can-define#167, but pending canjs/can-reflect#1


@matthewp commented on Fri Mar 31 2017

@christopherjbaker I think we need the same thing in can-map.


@christopherjbaker commented on Tue Apr 04 2017

Hmm. Adding it the same way to can-map would add a dependency to can-define, which seems counter-productive. I was going to implement it as-is now, but I think its better to wait for can-reflect.

@phillipskevin
Copy link
Contributor Author

duplicate of #66 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant