Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.attr({ ... }, "true") doesn't work #96

Open
phillipskevin opened this issue May 31, 2018 · 0 comments
Open

.attr({ ... }, "true") doesn't work #96

phillipskevin opened this issue May 31, 2018 · 0 comments

Comments

@phillipskevin
Copy link
Contributor

This doesn't work:

var map = new Map({ 0: "zero" });

map.attr({ 1: "one" }, "true");

since _setAttrs is looking explicitly for true.

This causes problems when using can-map as can-route.data since can-route stringifies the arguments:
https://github.com/canjs/can-route/blob/cf58f3ff398411fd8f61ebe29fc54888d037a30a/can-route.js#L318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillipskevin