Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo's /script folder structure is not intuitive #1058

Open
kimwnasptd opened this issue Sep 5, 2024 · 1 comment
Open

Repo's /script folder structure is not intuitive #1058

kimwnasptd opened this issue Sep 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kimwnasptd
Copy link
Contributor

kimwnasptd commented Sep 5, 2024

Bug Description

This was created after the discussion in #1038 (comment)

Right now the /scripts folder in the repo contains

  1. a lot of different scripts and it's not clear what users should expect to find in this directory
  2. scripts that are not used from our CI

We should re-organise the structure of this directory. For example we have scripts for deploying in airgap, gathering images from a bundle, and scripts for fetching bundle versions #1035

To quote the PR #1038 (comment)

the logical grouping of the script that gets all images + its supporting files (e.g. requirements.txt) should be placed in a path where it is obvious that it contains these sort of scripts. As a developer, I won't expect the fetch image scripts to be placed all around in scripts/ and in airgap/.
The suggestion we are making is to have all the scripts and supporting files in the same directory as we strive for correctness and a more logical grouping.

To Reproduce

Navigate into the /scripts dir, w

Environment

Current main from f54e015

Relevant Log Output

<none>

Additional Context

The dir also doesn't contain any README

@kimwnasptd kimwnasptd added the bug Something isn't working label Sep 5, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6209.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant