Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the use of KubernetesServicePatch library for all CKF charms #1194

Open
orfeas-k opened this issue Jan 15, 2025 · 1 comment
Open

Drop the use of KubernetesServicePatch library for all CKF charms #1194

orfeas-k opened this issue Jan 15, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@orfeas-k
Copy link
Contributor

Context

As per the library's docstring
https://github.com/canonical/observability-libs/blob/2ba744e224a09404fb05b00cfe56f9908441472e/lib/charms/observability_libs/v1/kubernetes_service_patch.py#L4-L11

"""# [DEPRECATED!] KubernetesServicePatch Library.
The `kubernetes_service_patch` library is DEPRECATED and will be removed in October 2025.
For patching the Kubernetes service created by Juju during the deployment of a charm,
`ops.Unit.set_ports` functionality should be used instead.

Thus we need to drop it from the charms using it before October 2025

What needs to get done

Replace with set_ports

Definition of Done

No CKF charm uses the deprecated library

@orfeas-k orfeas-k added the enhancement New feature or request label Jan 15, 2025
Copy link

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6739.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant