Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar items with subpages but not with a hyperlink is not clickable #1775

Open
nobuto-m opened this issue Mar 5, 2024 · 0 comments
Open

Comments

@nobuto-m
Copy link

nobuto-m commented Mar 5, 2024

This page as an example:
https://charmhub.io/manual-tls-certificates

Tutorials and How-to guides in the sidebar are not clickable to expand to see sub menus without knowing that the arrow is the only clickable element.

image

It's confirmed that it's a wrong usage of a vanilla framework class according to: canonical/vanilla-framework#5021
And the accordion component should used for such a sidebar item without a hyperlink instead:

So the markup in question is in the following page elements:

partial/_macros.html

{% else %}
<strong
class="p-side-navigation__text {% if expandable and element.children %}is-expandable{% endif %}"
{% if expandable and element.children %}aria-expanded={% if expanded %}"true"{% else %}"false"{% endif %}{% endif %}
>{{ element.navlink_text }}</strong>
{% endif %}

for example for the side items (Tutorials, How-to guides, etc.) in:
https://charmhub.io/manual-tls-certificates
as in the screenshot above.

topics/document.html

{% else %}
<strong
class="p-side-navigation__text {% if expandable and element.children %}is-expandable{% endif %}"
{% if expandable and element.children %}aria-expanded={% if expanded %}"true"{% else %}"false"{% endif %}{% endif %}
{% if element.is_active %}aria-current="page"{% endif %}
>{{ element.navlink_text }}</strong>
{% endif %}

for example for the side bar items (Performance, Kubernetes Charms, etc.) in:
https://charmhub.io/topics/canonical-observability-stack/reference

image

@nobuto-m nobuto-m changed the title In this documentation items are not clickable as a hyperlink Sidebar items with subpages but not with a hyperlink is not clickable Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant