Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper methods don't update their context, making harder to trace / follow in logs #186

Open
gboutry opened this issue Jul 31, 2024 · 1 comment · May be fixed by #187
Open

Wrapper methods don't update their context, making harder to trace / follow in logs #186

gboutry opened this issue Jul 31, 2024 · 1 comment · May be fixed by #187

Comments

@gboutry
Copy link

gboutry commented Jul 31, 2024

The data_interfaces library defines 4 wrapper methods:

data-platform-libs/lib/charms/data_platform_libs/v0/data_interfaces.py

Line 485 in c0d6387

def leader_only(f):

data-platform-libs/lib/charms/data_platform_libs/v0/data_interfaces.py

Line 500 in c0d6387

def juju_secrets_only(f):

data-platform-libs/lib/charms/data_platform_libs/v0/data_interfaces.py

Line 511 in c0d6387

def dynamic_secrets_only(f):

data-platform-libs/lib/charms/data_platform_libs/v0/data_interfaces.py

Line 524 in c0d6387

def either_static_or_dynamic_secrets(f):

These method do not update the wrapper context to the original method context, making it harder to trace / follow in logs.

In the case of the charm library: charms.tempo_k8s.v1.charm_tracing. it even makes impossible as the the trace_type method will fail: canonical/tempo-k8s-operator#155
@github-actions GitHub Actions
Copy link

https://warthogs.atlassian.net/browse/DPE-4995

@gboutry gboutry linked a pull request Jul 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MISC] update wrapper methods context gboutry/data-platform-libs
1 participant
@gboutry