We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The charmcraft templates use pyright for running static type checks on the charm.
However, pyright >= 1.1.352 does not work with NodeJS v12, that ships with Ubuntu 22.04. See: microsoft/pyright#7365
pyright >= 1.1.352
The workaround we found is pinning pyright in tox.ini:
deps = pyright==1.1.351
But that's unfortunately not a viable long-term solution, since NodeJS v12 has been unsupported for a long time now.
We did not install NodeJS in our workflows, so I'm assuming it's coming from the runners setup by this charm, correct?
Would it be possible to source NodeJS in the runners from a different, more up-to-date source (e.g., a snap)?
Try to run tox on any charm that follows the charmcraft templates or uses pyright.
tox
charmcraft
pyright
Official IS-maintained GitHub runners.
-
No response
The text was updated successfully, but these errors were encountered:
It seems we have to update node on the image to match the gh hosted ones: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#language-and-runtime
Sorry, something went wrong.
No branches or pull requests
Bug Description
The charmcraft templates use pyright for running static type checks on the charm.
However,
pyright >= 1.1.352
does not work with NodeJS v12, that ships with Ubuntu 22.04. See: microsoft/pyright#7365The workaround we found is pinning pyright in tox.ini:
But that's unfortunately not a viable long-term solution, since NodeJS v12 has been unsupported for a long time now.
We did not install NodeJS in our workflows, so I'm assuming it's coming from the runners setup by this charm, correct?
Would it be possible to source NodeJS in the runners from a different, more up-to-date source (e.g., a snap)?
To Reproduce
Try to run
tox
on any charm that follows thecharmcraft
templates or usespyright
.Environment
Official IS-maintained GitHub runners.
Relevant log output
Additional context
No response
The text was updated successfully, but these errors were encountered: