From 38b1f7d547b4881078b7d170d4399092ede4d4d1 Mon Sep 17 00:00:00 2001 From: Daniela Plascencia Date: Thu, 26 Oct 2023 12:30:31 +0200 Subject: [PATCH] skip: update based on feedback --- charms/kfp-persistence/src/charm.py | 2 ++ charms/kfp-profile-controller/src/charm.py | 7 +++++-- charms/kfp-profile-controller/tests/unit/test_operator.py | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/charms/kfp-persistence/src/charm.py b/charms/kfp-persistence/src/charm.py index 6a28e9fdc..c5546af9a 100755 --- a/charms/kfp-persistence/src/charm.py +++ b/charms/kfp-persistence/src/charm.py @@ -111,6 +111,8 @@ def __init__(self, *args, **kwargs): # Upstream defines this in the configmap persistenceagent-config-* "MULTIUSER": "true", "NAMESPACE": "", + "TL_SECONDS_AFTER_WORKFLOW_FINISH": "86400", + "NUM_WORKERS": "2", }, # provide function to pebble with which it can get service configuration from # relation diff --git a/charms/kfp-profile-controller/src/charm.py b/charms/kfp-profile-controller/src/charm.py index bec4aef3b..9e834d00c 100755 --- a/charms/kfp-profile-controller/src/charm.py +++ b/charms/kfp-profile-controller/src/charm.py @@ -45,8 +45,11 @@ "src/templates/secrets.yaml.j2", ] KFP_DEFAULT_PIPELINE_ROOT = "" -KFP_IMAGES_VERSION = "2.0.1" -METADATA_GRPC_SERVICE_HOST = "mlmd.kubeflow" +KFP_IMAGES_VERSION = "2.0.2" +# This service name must be the Service from the mlmd-operator +# FIXME: leaving it hardcoded now, but we should share this +# host and port through relation data +METADATA_GRPC_SERVICE_HOST = "metadata-grpc-service" METADATA_GRPC_SERVICE_PORT = "8080" NAMESPACE_LABEL = "pipelines.kubeflow.org/enabled" SYNC_CODE_FILE = Path("files/upstream/sync.py") diff --git a/charms/kfp-profile-controller/tests/unit/test_operator.py b/charms/kfp-profile-controller/tests/unit/test_operator.py index 240bc61b1..430606a2c 100644 --- a/charms/kfp-profile-controller/tests/unit/test_operator.py +++ b/charms/kfp-profile-controller/tests/unit/test_operator.py @@ -23,7 +23,7 @@ "CONTROLLER_PORT": 80, "DISABLE_ISTIO_SIDECAR": "false", "KFP_DEFAULT_PIPELINE_ROOT": "", - "KFP_VERSION": "2.0.1", + "KFP_VERSION": "2.0.2", "METADATA_GRPC_SERVICE_HOST": "mlmd.kubeflow", "METADATA_GRPC_SERVICE_PORT": "8080", "MINIO_ACCESS_KEY": "access-key",