Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to KFP 2.3.0 #579

Closed
kimwnasptd opened this issue Nov 13, 2024 · 4 comments
Closed

Upgrade to KFP 2.3.0 #579

kimwnasptd opened this issue Nov 13, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@kimwnasptd
Copy link
Contributor

kimwnasptd commented Nov 13, 2024

Context

This is primarily needed to resolve canonical/bundle-kubeflow#1120

We will need to upgrade KFP to 2.3.0 and introduce some configurations in the kfp-ui charm, to ensure logs are persisted. The reason we need 2.3.0 is to ensure we include this fix kubeflow/pipelines#11010

What needs to get done

  1. Upgrade the manifests for 2.3.0 #580
  2. Upgrade the rocks for 2.3.0 #581
  3. Ensure kfp-ui can show logs from Argo #582
  4. Create tracks for KFP 2.3.0 #586
  5. Release kfp-* charms to 2.3/stable #596
  6. Update 1.9 bundle with KFP 2.3 bundle-kubeflow#1147
  7. Update the "1.8 to 1.9" upgrade guide to reference KFP 2.3 #585
  8. Announce the use of KFP 2.3 in a discourse post for CKF 1.9 #587
  9. Update the KFP SDK in the UATs #594

Definition of Done

  1. CKF bundle 1.9 is using KFP 2.3.0
  2. All charms are released to the stable track for 2.3.0
  3. Pipeline logs are disappearing after 24h bundle-kubeflow#1120 is resolved
@kimwnasptd kimwnasptd added the enhancement New feature or request label Nov 13, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6539.

This message was autogenerated

@kimwnasptd
Copy link
Contributor Author

We expect this upgrade to be streamlined, as the manifests had minimal changes:

# cd kubeflow/pipelines
cd manifests/kustomize

git checkout 2.2.0
kustomize build env/cert-manager/platform-agnostic-multi-user > manifests-2-2-0.yaml

git checkout 2.3.0
kustomize build env/cert-manager/platform-agnostic-multi-user > manifests-2-3-0.yaml

diff manifests-2-2-0.yaml manifests-2-3-0.yaml

The above shows the following diff

2298d2297
<   - workflowtaskresults
3685c3684
<   appVersion: 2.3.0
---
>   appVersion: 2.2.0
4089c4088
<         image: gcr.io/ml-pipeline/cache-server:2.3.0
---
>         image: gcr.io/ml-pipeline/cache-server:2.2.0
4197c4196
<       - image: gcr.io/ml-pipeline/metadata-envoy:2.3.0
---
>       - image: gcr.io/ml-pipeline/metadata-envoy:2.2.0
4311c4310
<         image: gcr.io/ml-pipeline/metadata-writer:2.3.0
---
>         image: gcr.io/ml-pipeline/metadata-writer:2.2.0
4492c4491
<         image: gcr.io/ml-pipeline/api-server:2.3.0
---
>         image: gcr.io/ml-pipeline/api-server:2.2.0
4579c4578
<         image: gcr.io/ml-pipeline/persistenceagent:2.3.0
---
>         image: gcr.io/ml-pipeline/persistenceagent:2.2.0
4637c4636
<         image: gcr.io/ml-pipeline/scheduledworkflow:2.3.0
---
>         image: gcr.io/ml-pipeline/scheduledworkflow:2.2.0
4703,4707c4702
<         - name: FRONTEND_SERVER_NAMESPACE
<           valueFrom:
<             fieldRef:
<               fieldPath: metadata.namespace
<         image: gcr.io/ml-pipeline/frontend:2.3.0
---
>         image: gcr.io/ml-pipeline/frontend:2.2.0
4783c4778
<         image: gcr.io/ml-pipeline/viewer-crd-controller:2.3.0
---
>         image: gcr.io/ml-pipeline/viewer-crd-controller:2.2.0
4816c4811
<       - image: gcr.io/ml-pipeline/visualization-server:2.3.0
---
>       - image: gcr.io/ml-pipeline/visualization-server:2.2.0
4925c4920
<         - gcr.io/ml-pipeline/argoexec:v3.4.17-license-compliance
---
>         - gcr.io/ml-pipeline/argoexec:v3.4.16-license-compliance
4934c4929
<         image: gcr.io/ml-pipeline/workflow-controller:v3.4.17-license-compliance
---
>         image: gcr.io/ml-pipeline/workflow-controller:v3.4.16-license-compliance

@kimwnasptd
Copy link
Contributor Author

kimwnasptd commented Nov 29, 2024

Summary of the current state. We'll update KFP in CKF 1.9 to be 2.3. Alongside this bump there will be included:

  1. Pipeline logs are disappearing after 24h bundle-kubeflow#1120
  2. Can not retrieve the pipelines after upgrading Kubeflow from 1.8 to .19 #584

Regarding KFP logs and when upgrading from KFP 2.2 to 2.3 the following will happen:

  1. For KFP V2 Pipelines, the logs tab in the UI will now show the logs from new runs that will be created
  2. V1 Pipelines will not be affected, as the logs from each step are exposed in the Input/Output tab of a step

The fastest way to detect if a run is for V1 or V2 is by inspecting the UI. The images from #582 (comment) will make it more clear how V1 and V2 runs (and Pipeline definitions) are shown in the UI

@NohaIhab
Copy link
Contributor

NohaIhab commented Dec 3, 2024

KFP 2.3 is now integrated in CKF 1.9/stable, see the announcement and upgrade instructions

@NohaIhab NohaIhab closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants