From 35cfc6a49500f74ddd8085e0a14215ba878e7142 Mon Sep 17 00:00:00 2001 From: NohaIhab Date: Wed, 25 Oct 2023 10:07:08 +0000 Subject: [PATCH 1/4] fix: decrease idle period to 30 --- tests/integration/test_kfp_functional.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/integration/test_kfp_functional.py b/tests/integration/test_kfp_functional.py index f5d73f75..d5bc1d03 100644 --- a/tests/integration/test_kfp_functional.py +++ b/tests/integration/test_kfp_functional.py @@ -74,7 +74,7 @@ async def test_build_and_deploy(ops_test: OpsTest, request, lightkube_client): raise_on_blocked=False, # These apps block while waiting for each other to deploy/relate raise_on_error=True, timeout=3600, - idle_period=120, + idle_period=30, ) # ---- KFP API Server focused test cases From 5b135f14706b209d451ad6a54619391d0f5c4a39 Mon Sep 17 00:00:00 2001 From: NohaIhab Date: Wed, 25 Oct 2023 10:08:06 +0000 Subject: [PATCH 2/4] ci: add ssh --- .github/workflows/integrate.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml index 84f7a39f..476a68d0 100644 --- a/.github/workflows/integrate.yaml +++ b/.github/workflows/integrate.yaml @@ -95,7 +95,8 @@ jobs: channel: 1.25-strict/stable juju-channel: 3.1/stable charmcraft-channel: latest/candidate - + - name: Setup upterm session + uses: lhotari/action-upterm@v1 - run: | sg snap_microk8s -c "tox -e ${{ matrix.charm }}-integration" From bce92ad68b363fb3793afab30925982a40023614 Mon Sep 17 00:00:00 2001 From: NohaIhab Date: Wed, 25 Oct 2023 14:08:49 +0000 Subject: [PATCH 3/4] test: mysql raise on error false --- charms/kfp-api/tests/integration/test_charm.py | 1 + 1 file changed, 1 insertion(+) diff --git a/charms/kfp-api/tests/integration/test_charm.py b/charms/kfp-api/tests/integration/test_charm.py index 9c19595a..a5e2a447 100644 --- a/charms/kfp-api/tests/integration/test_charm.py +++ b/charms/kfp-api/tests/integration/test_charm.py @@ -87,6 +87,7 @@ async def test_relational_db_relation_with_mysql_relation(self, ops_test: OpsTes apps=["mysql-k8s"], status="active", raise_on_blocked=True, + raise_on_error=False, timeout=90 * 30, idle_period=20, ) From 3278ddb3268c3287861cb13bcb8928cfd8bfd328 Mon Sep 17 00:00:00 2001 From: NohaIhab Date: Wed, 25 Oct 2023 14:09:32 +0000 Subject: [PATCH 4/4] test: no ssh --- .github/workflows/integrate.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml index 476a68d0..6751510f 100644 --- a/.github/workflows/integrate.yaml +++ b/.github/workflows/integrate.yaml @@ -95,8 +95,8 @@ jobs: channel: 1.25-strict/stable juju-channel: 3.1/stable charmcraft-channel: latest/candidate - - name: Setup upterm session - uses: lhotari/action-upterm@v1 + # - name: Setup upterm session + # uses: lhotari/action-upterm@v1 - run: | sg snap_microk8s -c "tox -e ${{ matrix.charm }}-integration"